Skip to content

Conversation

@mikhail-aws
Copy link
Contributor

@mikhail-aws mikhail-aws commented Nov 21, 2023

Note:

  • Decouple log-level from dev and prod logging config. Can use different logging levels for both.
  • Add env variable to control log level. Introduce few levels: info, debug, error, panic. Default value is info. Still thinking about error and panic logs, probably redundant.
  • Add DEV_MODE env variable to enable development logging format.

#530

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@solmonk
Copy link
Contributor

solmonk commented Nov 21, 2023

can we update environment.md accordingly and remove GATEWAY_API_CONTROLLER_LOGLEVEL from code and docs?

@mikhail-aws
Copy link
Contributor Author

@solmonk, removed GATEWAY_API_CONTROLLER_LOGLEVEL from code

@mikhail-aws mikhail-aws merged commit 29b922b into aws:main Nov 21, 2023
@mikhail-aws mikhail-aws deleted the debug-log-flag branch November 21, 2023 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants