change FindServiceNetwork algo, use name and id match #566
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zijun726911
reviewed
Dec 11, 2023
zijun726911
reviewed
Dec 11, 2023
pkg/aws/services/vpclattice.go
Outdated
| ListServiceNetworkVpcAssociationsAsList(ctx context.Context, input *vpclattice.ListServiceNetworkVpcAssociationsInput) ([]*vpclattice.ServiceNetworkVpcAssociationSummary, error) | ||
| ListServiceNetworkServiceAssociationsAsList(ctx context.Context, input *vpclattice.ListServiceNetworkServiceAssociationsInput) ([]*vpclattice.ServiceNetworkServiceAssociationSummary, error) | ||
| FindServiceNetwork(ctx context.Context, name string, accountId string) (*ServiceNetworkInfo, error) | ||
| FindServiceNetwork(ctx context.Context, name string) (*ServiceNetworkInfo, error) |
Contributor
There was a problem hiding this comment.
Need to change name to nameOrId string in interface?
| }) | ||
| idMatch := utils.SliceFilter(allSn, func(snSum *vpclattice.ServiceNetworkSummary) bool { | ||
| return aws.StringValue(snSum.Id) == nameOrId | ||
| }) |
Contributor
There was a problem hiding this comment.
For the discussion in slack, filter by name then id make sense. We could also add another filter by ARN, i.e. change function name to
FindServiceNetwork(ctx context.Context, nameOrIdOrArn string) and add a arnMatch=
Contributor
Author
There was a problem hiding this comment.
I would drop ID and use ARN only
Contributor
Author
There was a problem hiding this comment.
ARN is not a valid name for Gateway, "/" if not allowed
mikhail-aws
force-pushed
the
shared-sn
branch
from
dbbe7e1 to
6597294
Compare
mikhail-aws
changed the title
mikhail-aws
force-pushed
the
shared-sn
branch
from
2a89b78 to
e8e4bdc
Compare
mikhail-aws
changed the title
mikhail-aws
force-pushed
the
shared-sn
branch
from
e8e4bdc to
f359d36
Compare
mikhail-aws
force-pushed
the
shared-sn
branch
from
f359d36 to
606ba58
Compare
zijun726911
approved these changes
Dec 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note:
Address bug for RAM sharing scenario with ServiceNetwork. Currently FindServiceNetwork will not find shared SNs, but if find will fail on fetching Tags. It's not possible to fetch tags for external resources.
Important changes in vpclattice.go
New algorithm will do:
Added unit tests.
Manually tested with shared SN scenarios.
New error log example:
Related #565