-
Notifications
You must be signed in to change notification settings - Fork 71
Cross-Account e2e Tests + Conflicted Gateway Status #578
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
mikhail-aws
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Status updates for gateway require more work and thought, existing code is not in good shape and new code does not make it better. I suggest move it into different PR.
Integ-tests have lots of duplicated code starting from Makefile, framework setup, and tests cases it-self. If you abstract same code into well defined functions, and re-use existing code as much as you can this PR would be under 200 lines of code.
|
Special highlight on duplicated code - last time when I did refactoring for FindServiceNetwork I had hard times with accesslog policy tests, surprisingly. We should take it more serious. |
…ing Gateway name conflict, general code cleanliness improvements
|
New E2E tests still pass: |
zijun726911
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks to add new e2e tests! overall LGTM!
60c4f7d to
12148b2
Compare
mikhail-aws
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, thank you
What type of PR is this?
feature + tests
Which issue does this PR fix:
#567
What does this PR do / Why do we need it:
Conflictedwhen there is a name conflictPendingsharingSECONDARY_ACCOUNT_TEST_ROLE_ARN, which is used by the new test suite to assume the secondary account, which currently just shares resources to the primary accountsharing-test, which runs the new suitesharingsuiteIf an issue # is not available please add repro steps and logs from aws-gateway-controller showing the issue:
N/A
Testing done on this change:
Automation added to e2e:
sharingsuiteWill this PR introduce any new dependencies?:
No
Will this break upgrades or downgrades. Has updating a running cluster been tested?:
No
Does this PR introduce any user-facing change?:
No
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.