Skip to content

Conversation

@guessi
Copy link
Contributor

@guessi guessi commented Feb 10, 2024

What type of PR is this?

documentation

Which issue does this PR fix:

n/a

What does this PR do / Why do we need it:

Content of examples/ipv6-cluster.yaml is for eksctl but not kubectl.

# To create an IPv6 cluster
kubectl apply -f examples/ipv6-cluster.yaml

---
apiVersion: eksctl.io/v1alpha5
kind: ClusterConfig
metadata:
name: my-ipv6-cluster
region: us-west-2
kubernetesNetworkConfig:
ipFamily: IPv6
addons:
- name: vpc-cni
version: latest
- name: coredns
version: latest
- name: kube-proxy
version: latest
iam:
withOIDC: true
managedNodeGroups:
- name: my-ipv6-nodegroup
instanceType: t3.medium

If an issue # is not available please add repro steps and logs from aws-gateway-controller showing the issue:

n/a

Testing done on this change:

Automation added to e2e:

Will this PR introduce any new dependencies?:

Will this break upgrades or downgrades. Has updating a running cluster been tested?:

Does this PR introduce any user-facing change?:


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@solmonk solmonk enabled auto-merge (squash) February 13, 2024 22:59
Copy link
Contributor

@solmonk solmonk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for spotting this!

@solmonk solmonk merged commit 39561c3 into aws:main Feb 13, 2024
@guessi guessi deleted the patch-1 branch February 15, 2024 01:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants