Skip to content

Conversation

@u-kai
Copy link
Contributor

@u-kai u-kai commented Feb 16, 2025

What type of PR is this?
bug

Which issue does this PR fix:
#669

What does this PR do / Why do we need it:
Fixed incomplete detection of events related to TLSRoute, as described in the issue.

If an issue # is not available please add repro steps and logs from aws-gateway-controller showing the issue:

Testing done on this change:

With this change, as shown in the attached image, when the podIP changes, the TargetGroup association will also be updated accordingly.
image

Automation added to e2e:

None
Will this PR introduce any new dependencies?:

None
Will this break upgrades or downgrades. Has updating a running cluster been tested?:
No, this change does not break upgrades or downgrades.
Unit tests and end-to-end (e2e) tests confirm that the system behaves as expected.

Does this PR introduce any user-facing change?:


Do all end-to-end tests successfully pass when running make e2e-test?:

SECONDARY_ACCOUNT_TEST_ROLE_ARN=arn:aws:iam:xxxxxxxxxxxx:role/TestRole REGION=ap-northeast-1  make e2e-test
...
------------------------------
[SynchronizedAfterSuite] 
/Users/kai/aws-application-networking-k8s/test/suites/integration/suite_test.go:72
{"level":"info","ts":"2025-02-16T19:42:31.835+0900","caller":"test/framework.go:266","msg":"Deleting objects: *v1.Gateway/test-gateway, *v1.Pod/grpc-runner"}
{"level":"info","ts":"2025-02-16T19:42:31.884+0900","caller":"test/framework.go:285","msg":"Waiting for NotFound, objects: *v1.Gateway/test-gateway, *v1.Pod/grpc-runner"}
[SynchronizedAfterSuite] PASSED [32.103 seconds]
------------------------------

Ran 69 of 69 Specs in 2844.480 seconds
SUCCESS! -- 69 Passed | 0 Failed | 0 Pending | 0 Skipped

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@ghost ghost merged commit 60fe682 into aws:main Feb 18, 2025
1 of 2 checks passed
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant