Skip to content

Conversation

@rlymbur
Copy link
Contributor

@rlymbur rlymbur commented May 7, 2025

What type of PR is this?

Bug

Which issue does this PR fix:

N/A

What does this PR do / Why do we need it:

This corrects current E2E test failures to provide a clean baseline for upcoming changes. It also temporarily skips access log integration tests until these can be stabilized and reintroduced. #733 was created to track adding these tests back.

If an issue # is not available please add repro steps and logs from aws-gateway-controller showing the issue:

N/A

Testing done on this change:

Ran E2E tests against my local cluster.

Automation added to e2e:

No

Will this PR introduce any new dependencies?:

No

Will this break upgrades or downgrades. Has updating a running cluster been tested?:

No

Does this PR introduce any user-facing change?:

No

Do all end-to-end tests successfully pass when running make e2e-test?:

------------------------------

Ran 56 of 69 Specs in 3199.321 seconds
SUCCESS! -- 56 Passed | 0 Failed | 0 Pending | 13 Skipped
--- PASS: TestIntegration (3199.32s)
PASS
ok      github.com/aws/aws-application-networking-k8s/test/suites/integration   3199.915s

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@rlymbur rlymbur requested a review from mikestvz May 7, 2025 22:12
@rlymbur rlymbur self-assigned this May 7, 2025
@rlymbur rlymbur added bug Something isn't working test case labels May 7, 2025
Copy link
Contributor

@mikestvz mikestvz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to revisit the timeout and what is triggering the additional latency
#733

@rlymbur rlymbur added this pull request to the merge queue May 7, 2025
@rlymbur rlymbur removed this pull request from the merge queue due to a manual request May 7, 2025
@rlymbur rlymbur added this pull request to the merge queue May 7, 2025
Merged via the queue into aws:main with commit 2426ab4 May 7, 2025
2 checks passed
@rlymbur rlymbur deleted the fix-e2e-tests branch May 7, 2025 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working test case

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants