Skip to content

Non default ns #81

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 31, 2023
Merged

Non default ns #81

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cc50139
Update readme on how to run in debug mode
liwenwu-amazon Jan 31, 2023
d16aa4d
Set serviceimport namespace instead of hard code to default
liwenwu-amazon Jan 31, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,9 @@ kubectl apply -f config/crds/bases/multicluster.x-k8s.io_serviceimports.yaml

# Run the controller against the Kubernetes cluster pointed to by `kubectl config current-context`
make run

# or run it in debug mode
GATEWAY_API_CONTROLLER_LOGLEVEL=debug make run
```

## End-to-End Testing
Expand Down
3 changes: 3 additions & 0 deletions pkg/gateway/model_build_listener.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,6 +111,9 @@ func (t *latticeServiceModelBuildTask) buildListener(ctx context.Context) error
if string(*httpBackendRef.Kind) == "ServiceImport" {
is_import = true
targetgroupNamespace = "default"
Copy link

@M00nF1sh M00nF1sh Jan 31, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not related to this change:

should the default namespace be "default" or the HTTPRoute's namespace?

Copy link
Contributor Author

@liwenwu-amazon liwenwu-amazon Jan 31, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, this is to build the default rule for listener. It needs to pick one target group.
In this case, if 1st one is a service import, it needs to make sure the namespace is set

if httpBackendRef.BackendObjectReference.Namespace != nil {
targetgroupNamespace = string(*httpBackendRef.BackendObjectReference.Namespace)
}
targetgroupName = string(httpBackendRef.BackendObjectReference.Name)

}
Expand Down
3 changes: 3 additions & 0 deletions pkg/gateway/model_build_rule.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,9 @@ func (t *latticeServiceModelBuildTask) buildRules(ctx context.Context) error {
*/
ruleTG.Name = string(httpBackendRef.BackendObjectReference.Name)
ruleTG.Namespace = "default"
if httpBackendRef.BackendObjectReference.Namespace != nil {
ruleTG.Namespace = string(*httpBackendRef.BackendObjectReference.Namespace)
}
ruleTG.IsServiceImport = true

if httpBackendRef.Weight != nil {
Expand Down