Skip to content

Conversation

@ghost
Copy link

@ghost ghost commented Sep 18, 2025

What type of PR is this?
Clean-up

Which issue does this PR fix:
N/A - Proactive dependency maintenance

What does this PR do / Why do we need it:
This PR upgrades key Kubernetes dependencies to their latest versions and fixes API compatibility issues introduced by the upgrades. The changes include:

  1. Dependency Upgrades:

    • sigs.k8s.io/controller-runtime: v0.20.2 → v0.22.1
    • k8s.io/api: v0.32.2 → v0.34.1
    • k8s.io/client-go: v0.32.2 → v0.34.1
    • github.com/stretchr/testify: v1.10.0 → v1.11.1
    • golangci-lint: v1.63.4 → v2.4.0
    • Go version: 1.23.6 → 1.24.0
  2. API Compatibility Fixes:

    • Fixed apiutil.RESTClientForGVK function signature change (added missing boolean parameter)
    • Replaced deprecated res.Requeue with RequeueAfter pattern in controllers
    • Migrated from deprecated corev1.Endpoints to discoveryv1.EndpointSlice API
    • Updated test assertions to use RequeueAfter instead of deprecated Requeue field

These upgrades provide the latest bug fixes, security patches, and performance improvements from the Kubernetes ecosystem.

If an issue # is not available please add repro steps and logs from aws-gateway-controller showing the issue:
N/A - This is a proactive maintenance upgrade

Testing done on this change:

  • All Go builds pass: go build ./...
  • All Go vet checks pass: go vet ./...
  • Updated unit tests to use new APIs (EndpointSlice instead of Endpoints)
  • Verified controller logic maintains same behavior with new RequeueAfter pattern

Automation added to e2e:
No new e2e tests required - existing tests cover the same functionality with updated APIs

Will this PR introduce any new dependencies?:
No new external dependencies. Only upgraded existing Kubernetes client libraries to newer versions.

Will this break upgrades or downgrades. Has updating a running cluster been tested?:
No breaking changes for running clusters. The changes are internal API usage updates that maintain backward compatibility for deployed resources. The controller behavior remains functionally identical.

Does this PR introduce any user-facing change?:
No user-facing changes. All modifications are internal dependency upgrades and API compatibility fixes.

Updated Kubernetes dependencies to latest versions (controller-runtime v0.22.1, k8s.io/api v0.34.1, k8s.io/client-go v0.34.1) and fixed deprecated API usage for improved compatibility and security.

@ghost ghost self-assigned this Sep 18, 2025
@ghost ghost added the dependencies Pull requests that update a dependency file label Sep 18, 2025
@ghost ghost enabled auto-merge September 18, 2025 21:56
@ghost ghost changed the title Dependency upgrades Dependency Upgrades Sep 18, 2025
@ghost ghost disabled auto-merge September 18, 2025 23:17
@ghost ghost added this pull request to the merge queue Sep 18, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 18, 2025
@ghost ghost enabled auto-merge September 18, 2025 23:23
@ghost ghost added this pull request to the merge queue Sep 18, 2025
Merged via the queue into aws:main with commit 4e4f33c Sep 19, 2025
3 checks passed
@ghost ghost deleted the dependency-upgrades branch September 19, 2025 17:43
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant