Skip to content

Conversation

@SinghVikram97
Copy link
Contributor

@SinghVikram97 SinghVikram97 commented Oct 22, 2025

What type of PR is this?
Fix

Which issue does this PR fix:
#831

What does this PR do / Why do we need it:
Remove TLSRoute CRD from Helm chart. And updated documentation.
Note: I haven't removed TLSRoute CRD used to generate the deploy-v*.yaml files which is used for non-helm use cases and also used by our e2e-test setup.

Testing done on this change:

(25-10-22 22:09:26) <0> [~/eks/aws-application-networking-k8s]  
dev-dsk-vbedi-2a-e8762507 % helm install test-gateway-controller ./helm \
    --namespace aws-application-networking-system \
    --create-namespace \
    --set=serviceAccount.create=false \
    --set=awsRegion=us-west-2 \
    --set=clusterName=test-cluster \
    --set=log.level=info
NAME: test-gateway-controller
LAST DEPLOYED: Wed Oct 22 22:11:35 2025
NAMESPACE: aws-application-networking-system
STATUS: deployed
REVISION: 1
TEST SUITE: None
NOTES:
aws-gateway-controller-chart has been installed.
This chart deploys "public.ecr.aws/aws-application-networking-k8s/aws-gateway-controller:".

Check its status by running:
  kubectl --namespace aws-application-networking-system get pods -l "app.kubernetes.io/instance=test-gateway-controller"

The controller is running in "cluster" mode.

(25-10-22 22:11:36) <0> [~/eks/aws-application-networking-k8s]  
dev-dsk-vbedi-2a-e8762507 % kubectl get crd
NAME                                                    CREATED AT
accesslogpolicies.application-networking.k8s.aws        2025-10-22T22:11:33Z
dnsendpoints.externaldns.k8s.io                         2025-10-22T22:11:33Z
iamauthpolicies.application-networking.k8s.aws          2025-10-22T22:11:33Z
serviceexports.application-networking.k8s.aws           2025-10-22T22:11:33Z
serviceimports.application-networking.k8s.aws           2025-10-22T22:11:33Z
targetgrouppolicies.application-networking.k8s.aws      2025-10-22T22:11:33Z
tlsroutes.gateway.networking.k8s.io                     2025-10-22T22:11:33Z
vpcassociationpolicies.application-networking.k8s.aws   2025-10-22T22:11:33Z

(25-10-22 22:11:46) <0> [~/eks/aws-application-networking-k8s]  
dev-dsk-vbedi-2a-e8762507 % rm helm/crds/gateway.networking.k8s.io_tlsroutes.yaml

(25-10-22 22:11:53) <0> [~/eks/aws-application-networking-k8s]  
dev-dsk-vbedi-2a-e8762507 % ls helm/crds | grep tlsroutes

(25-10-22 22:12:03) <1> [~/eks/aws-application-networking-k8s]  
dev-dsk-vbedi-2a-e8762507 % helm upgrade test-gateway-controller ./helm \
    --namespace aws-application-networking-system  
Release "test-gateway-controller" has been upgraded. Happy Helming!
NAME: test-gateway-controller
LAST DEPLOYED: Wed Oct 22 22:12:23 2025
NAMESPACE: aws-application-networking-system
STATUS: deployed
REVISION: 2
TEST SUITE: None
NOTES:
aws-gateway-controller-chart has been installed.
This chart deploys "public.ecr.aws/aws-application-networking-k8s/aws-gateway-controller:".

Check its status by running:
  kubectl --namespace aws-application-networking-system get pods -l "app.kubernetes.io/instance=test-gateway-controller"

The controller is running in "cluster" mode.

(25-10-22 22:12:24) <0> [~/eks/aws-application-networking-k8s]  
dev-dsk-vbedi-2a-e8762507 % kubectl get crd                                      
NAME                                                    CREATED AT
accesslogpolicies.application-networking.k8s.aws        2025-10-22T22:11:33Z
dnsendpoints.externaldns.k8s.io                         2025-10-22T22:11:33Z
iamauthpolicies.application-networking.k8s.aws          2025-10-22T22:11:33Z
serviceexports.application-networking.k8s.aws           2025-10-22T22:11:33Z
serviceimports.application-networking.k8s.aws           2025-10-22T22:11:33Z
targetgrouppolicies.application-networking.k8s.aws      2025-10-22T22:11:33Z
tlsroutes.gateway.networking.k8s.io                     2025-10-22T22:11:33Z
vpcassociationpolicies.application-networking.k8s.aws   2025-10-22T22:11:33Z

Automation added to e2e:
NA

Will this PR introduce any new dependencies?:
No

Will this break upgrades or downgrades. Has updating a running cluster been tested?:
No breaking changes

Does this PR introduce any user-facing change?:
No

Do all end-to-end tests successfully pass when running make e2e-test?:
Yes

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@SinghVikram97 SinghVikram97 added this pull request to the merge queue Oct 23, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 23, 2025
@SinghVikram97 SinghVikram97 added this pull request to the merge queue Oct 23, 2025
Merged via the queue into main with commit d525f03 Oct 23, 2025
5 checks passed
@rlymbur rlymbur deleted the vbedi_issue_831 branch October 30, 2025 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants