Support for Vanity Name and Bring Your Own Certificates #85
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liwenwu-amazon
changed the title
M00nF1sh
reviewed
Feb 13, 2023
pkg/gateway/model_build_listener.go
Outdated
| protocol = section.Protocol | ||
|
|
||
| if section.TLS != nil { | ||
| if *section.TLS.Mode == v1alpha2.TLSModeTerminate { |
There was a problem hiding this comment.
is it possible that section.TLS.Mode == nil?
Contributor
Author
There was a problem hiding this comment.
Good point. Let me add a check to avoid crash.
M00nF1sh
reviewed
Feb 13, 2023
| const ( | ||
| resourceIDListenerConfig = "ListenerConfig" | ||
|
|
||
| awsCustomCertARN = "application-networking.k8s.aws/certificate-arn" |
There was a problem hiding this comment.
is it possible to specify multiple certificates per gateway?
Contributor
Author
There was a problem hiding this comment.
Today, Lattice only allow one certificate per lattice-service/HTTPRoute. Gateway can have multiple sections where each section has its own certificates ARN
M00nF1sh
approved these changes
Feb 13, 2023
M00nF1sh
left a comment
M00nF1sh
left a comment
There was a problem hiding this comment.
/lgtm
looks good to me from the code perspective.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #16, if available:
Description of changes:
Here are detail
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.