-
Notifications
You must be signed in to change notification settings - Fork 74
fix: chokidar and npm rely on outdated version of tar #1059
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1059 +/- ##
==========================================
- Coverage 87.70% 87.64% -0.06%
==========================================
Files 72 72
Lines 10102 10121 +19
Branches 1335 1334 -1
==========================================
+ Hits 8860 8871 +11
- Misses 1217 1225 +8
Partials 25 25
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Upgrades key Node tooling dependencies to move off tar v6 by bumping chokidar (for cdk watch) and npm (for cli-integ), along with necessary code and build config adjustments.
Changes:
- Upgrade
chokidarfrom v3 → v4 across CLI, toolkit-lib, and integ-runner (plus updated watch event typing/filtering). - Upgrade
npmfrom v10 → v11 in@aws-cdk-testing/cli-integ(and update lockfile graph, includingtarv7). - Update bundling config/tasks and adjust watcher shutdown behavior/tests (remove
unrefusage).
Reviewed changes
Copilot reviewed 17 out of 18 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| yarn.lock | Updates the dependency graph for chokidar v4, npm v11, and newer tar/related transitive deps. |
| packages/aws-cdk/package.json | Bumps runtime dependency chokidar to ^4. |
| packages/aws-cdk/lib/cli/cdk-toolkit.ts | Updates watch handling for chokidar v4 event typing/filtering. |
| packages/aws-cdk/THIRD_PARTY_LICENSES | Updates bundled third-party attributions (currently missing chokidar attribution). |
| packages/aws-cdk/.projen/tasks.json | Updates node-backpack pack/validate command lines (removes fsevents externalization). |
| packages/aws-cdk/.projen/deps.json | Aligns projen-managed deps to chokidar@^4. |
| packages/@aws-cdk/toolkit-lib/test/actions/watch.test.ts | Updates tests to reflect watcher shutdown changes (no unref). |
| packages/@aws-cdk/toolkit-lib/package.json | Bumps runtime dependency chokidar to ^4. |
| packages/@aws-cdk/toolkit-lib/lib/toolkit/toolkit.ts | Updates watch logic to accept chokidar v4 event types and removes unref. |
| packages/@aws-cdk/toolkit-lib/.projen/deps.json | Aligns projen-managed deps to chokidar@^4. |
| packages/@aws-cdk/integ-runner/package.json | Bumps runtime dependency chokidar to ^4. |
| packages/@aws-cdk/integ-runner/lib/runner/integ-test-runner.ts | Updates chokidar watch event typing/filtering for v4. |
| packages/@aws-cdk/integ-runner/THIRD_PARTY_LICENSES | Updates bundled third-party attributions (currently missing chokidar attribution). |
| packages/@aws-cdk/integ-runner/.projen/tasks.json | Updates node-backpack pack/validate command lines (removes fsevents externalization). |
| packages/@aws-cdk/integ-runner/.projen/deps.json | Aligns projen-managed deps to chokidar@^4. |
| packages/@aws-cdk-testing/cli-integ/package.json | Bumps runtime dependency npm to ^11. |
| packages/@aws-cdk-testing/cli-integ/.projen/deps.json | Aligns projen-managed deps to npm@^11. |
| .projenrc.ts | Updates projen project dependency declarations and bundling configuration to match new versions. |
Comments suppressed due to low confidence (2)
packages/aws-cdk/THIRD_PARTY_LICENSES:21572
THIRD_PARTY_LICENSESno longer contains an attribution entry forchokidar, butaws-cdkstill declareschokidaras a runtime dependency (now ^4). Please regenerate/update the attributions so the new chokidar version (and any new transitive deps likereaddirp@^4) are included; otherwise the published package/bundle will be missing required third-party notices.
packages/@aws-cdk/integ-runner/THIRD_PARTY_LICENSES:21414THIRD_PARTY_LICENSESno longer contains an attribution entry forchokidar, but@aws-cdk/integ-runnerstill declareschokidaras a runtime dependency (now ^4). Please regenerate/update the attributions so the new chokidar version (and any new transitive deps likereaddirp@^4) are included; otherwise the published package/bundle will be missing required third-party notices.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Fixes #1044
Gets us off of tar mv 6 by upgrading chokidar from v3 -> v4 (used by
cdk watch), and npm from v10 -> v11 (used bycli-integ)By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license