Skip to content

Conversation

@iankhou
Copy link
Contributor

@iankhou iankhou commented Jan 24, 2026

Fixes #1044

Gets us off of tar mv 6 by upgrading chokidar from v3 -> v4 (used by cdk watch), and npm from v10 -> v11 (used by cli-integ)


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added the p2 label Jan 24, 2026
@aws-cdk-automation aws-cdk-automation requested a review from a team January 24, 2026 01:18
@iankhou iankhou changed the title Iankhou chokidar npm upgrade fix: chokidar and npm rely on outdated version of tar Jan 24, 2026
Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@codecov-commenter
Copy link

Codecov Report

❌ Patch coverage is 85.00000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 87.64%. Comparing base (78ed91b) to head (8b1a595).

Files with missing lines Patch % Lines
packages/aws-cdk/lib/cli/cdk-toolkit.ts 85.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1059      +/-   ##
==========================================
- Coverage   87.70%   87.64%   -0.06%     
==========================================
  Files          72       72              
  Lines       10102    10121      +19     
  Branches     1335     1334       -1     
==========================================
+ Hits         8860     8871      +11     
- Misses       1217     1225       +8     
  Partials       25       25              
Flag Coverage Δ
suite.unit 87.64% <85.00%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@iankhou iankhou marked this pull request as ready for review January 24, 2026 02:26
@iankhou iankhou requested review from Copilot and removed request for a team January 24, 2026 02:26
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Upgrades key Node tooling dependencies to move off tar v6 by bumping chokidar (for cdk watch) and npm (for cli-integ), along with necessary code and build config adjustments.

Changes:

  • Upgrade chokidar from v3 → v4 across CLI, toolkit-lib, and integ-runner (plus updated watch event typing/filtering).
  • Upgrade npm from v10 → v11 in @aws-cdk-testing/cli-integ (and update lockfile graph, including tar v7).
  • Update bundling config/tasks and adjust watcher shutdown behavior/tests (remove unref usage).

Reviewed changes

Copilot reviewed 17 out of 18 changed files in this pull request and generated no comments.

Show a summary per file
File Description
yarn.lock Updates the dependency graph for chokidar v4, npm v11, and newer tar/related transitive deps.
packages/aws-cdk/package.json Bumps runtime dependency chokidar to ^4.
packages/aws-cdk/lib/cli/cdk-toolkit.ts Updates watch handling for chokidar v4 event typing/filtering.
packages/aws-cdk/THIRD_PARTY_LICENSES Updates bundled third-party attributions (currently missing chokidar attribution).
packages/aws-cdk/.projen/tasks.json Updates node-backpack pack/validate command lines (removes fsevents externalization).
packages/aws-cdk/.projen/deps.json Aligns projen-managed deps to chokidar@^4.
packages/@aws-cdk/toolkit-lib/test/actions/watch.test.ts Updates tests to reflect watcher shutdown changes (no unref).
packages/@aws-cdk/toolkit-lib/package.json Bumps runtime dependency chokidar to ^4.
packages/@aws-cdk/toolkit-lib/lib/toolkit/toolkit.ts Updates watch logic to accept chokidar v4 event types and removes unref.
packages/@aws-cdk/toolkit-lib/.projen/deps.json Aligns projen-managed deps to chokidar@^4.
packages/@aws-cdk/integ-runner/package.json Bumps runtime dependency chokidar to ^4.
packages/@aws-cdk/integ-runner/lib/runner/integ-test-runner.ts Updates chokidar watch event typing/filtering for v4.
packages/@aws-cdk/integ-runner/THIRD_PARTY_LICENSES Updates bundled third-party attributions (currently missing chokidar attribution).
packages/@aws-cdk/integ-runner/.projen/tasks.json Updates node-backpack pack/validate command lines (removes fsevents externalization).
packages/@aws-cdk/integ-runner/.projen/deps.json Aligns projen-managed deps to chokidar@^4.
packages/@aws-cdk-testing/cli-integ/package.json Bumps runtime dependency npm to ^11.
packages/@aws-cdk-testing/cli-integ/.projen/deps.json Aligns projen-managed deps to npm@^11.
.projenrc.ts Updates projen project dependency declarations and bundling configuration to match new versions.
Comments suppressed due to low confidence (2)

packages/aws-cdk/THIRD_PARTY_LICENSES:21572

  • THIRD_PARTY_LICENSES no longer contains an attribution entry for chokidar, but aws-cdk still declares chokidar as a runtime dependency (now ^4). Please regenerate/update the attributions so the new chokidar version (and any new transitive deps like readdirp@^4) are included; otherwise the published package/bundle will be missing required third-party notices.
    packages/@aws-cdk/integ-runner/THIRD_PARTY_LICENSES:21414
  • THIRD_PARTY_LICENSES no longer contains an attribution entry for chokidar, but @aws-cdk/integ-runner still declares chokidar as a runtime dependency (now ^4). Please regenerate/update the attributions so the new chokidar version (and any new transitive deps like readdirp@^4) are included; otherwise the published package/bundle will be missing required third-party notices.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@mrgrain mrgrain added this pull request to the merge queue Jan 24, 2026
Merged via the queue into main with commit ba59816 Jan 24, 2026
40 checks passed
@mrgrain mrgrain deleted the iankhou-chokidar-npm-upgrade branch January 24, 2026 18:36
@github-actions github-actions bot added bug p1 and removed p2 labels Jan 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

aws-cdk: CVE-2026-23745

5 participants