Skip to content

chore: improve defense in depth of integ test workflow#1558

Merged
aws-cdk-automation merged 1 commit into
mainfrom
mrgrain/chore/integ-tests-defense-in-depth
May 28, 2026
Merged

chore: improve defense in depth of integ test workflow#1558
aws-cdk-automation merged 1 commit into
mainfrom
mrgrain/chore/integ-tests-defense-in-depth

Conversation

@mrgrain
Copy link
Copy Markdown
Contributor

@mrgrain mrgrain commented May 27, 2026

Improves the security posture of the integration test workflow by deferring OIDC credential acquisition until just before tests run, rather than at the start of the job. This is defense in depth — while the workflow's ambient identity is trusted and any step could assume the OIDC role, delaying credential materialization reduces the window where credentials are easily accessible to earlier setup steps (git identity, verdaccio, version resolution).

Additionally upgrades GitHub Actions to their latest major versions (checkout@v6, setup-node@v6, configure-aws-credentials@v6, setup-java@v5) and switches artifact downloads from name-based to artifact-id-based resolution for more precise artifact targeting.

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions Bot added the p2 label May 27, 2026
@aws-cdk-automation aws-cdk-automation requested a review from a team May 27, 2026 15:43
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented May 27, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.18%. Comparing base (b362949) to head (5ff2b91).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1558      +/-   ##
==========================================
+ Coverage   88.16%   88.18%   +0.01%     
==========================================
  Files          76       76              
  Lines       10841    10841              
  Branches     1494     1493       -1     
==========================================
+ Hits         9558     9560       +2     
+ Misses       1255     1253       -2     
  Partials       28       28              
Flag Coverage Δ
suite.unit 88.18% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mrgrain mrgrain force-pushed the mrgrain/chore/integ-tests-defense-in-depth branch from a6e64e9 to 5ff2b91 Compare May 28, 2026 10:17
uses: 'actions/setup-node@v6',
with: {
'node-version': nodeVersion,
'package-manager-cache': false,
Copy link
Copy Markdown
Contributor Author

@mrgrain mrgrain May 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Already disabled for yarn by default, just making this explicit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants