chore: improve defense in depth of integ test workflow#1558
Merged
aws-cdk-automation merged 1 commit intoMay 28, 2026
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1558 +/- ##
==========================================
+ Coverage 88.16% 88.18% +0.01%
==========================================
Files 76 76
Lines 10841 10841
Branches 1494 1493 -1
==========================================
+ Hits 9558 9560 +2
+ Misses 1255 1253 -2
Partials 28 28
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
a6e64e9 to
5ff2b91
Compare
mrgrain
commented
May 28, 2026
| uses: 'actions/setup-node@v6', | ||
| with: { | ||
| 'node-version': nodeVersion, | ||
| 'package-manager-cache': false, |
Contributor
Author
There was a problem hiding this comment.
Already disabled for yarn by default, just making this explicit.
rix0rrr
approved these changes
May 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improves the security posture of the integration test workflow by deferring OIDC credential acquisition until just before tests run, rather than at the start of the job. This is defense in depth — while the workflow's ambient identity is trusted and any step could assume the OIDC role, delaying credential materialization reduces the window where credentials are easily accessible to earlier setup steps (git identity, verdaccio, version resolution).
Additionally upgrades GitHub Actions to their latest major versions (
checkout@v6,setup-node@v6,configure-aws-credentials@v6,setup-java@v5) and switches artifact downloads from name-based to artifact-id-based resolution for more precise artifact targeting.Checklist
actions/checkout@v6: https://github.com/actions/checkout/releases/tag/v6.0.0actions/setup-node@v6: https://github.com/actions/setup-node/releases/tag/v6.0.0aws-actions/configure-aws-credentials@v6: https://github.com/aws-actions/configure-aws-credentials/releases/tag/v6.0.0actions/setup-java@v5: https://github.com/actions/setup-java/releases/tag/v5.0.0By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license