refactor: use WorkspaceJsiiBuild from cdklabs-projen-project-types#1565
Merged
Merged
Conversation
…stead of JsiiBuild
Contributor
Dependency ReviewThe following issues were found:
License Issuesyarn.lock
OpenSSF ScorecardScorecard details
Scanned Files
|
mrgrain
force-pushed
the
mrgrain/chore/jsii-build-from-upstream
branch
from
8f54f8e to
bda1eef
Compare
mrgrain
commented
May 28, 2026
Contributor
Author
There was a problem hiding this comment.
removing the now redundant file
mrgrain
commented
May 28, 2026
| fixupTestTask(cloudAssemblySchema); | ||
|
|
||
| new JsiiBuild(cloudAssemblySchema, { | ||
| cloudAssemblySchema.with(new yarn.WorkspaceJsiiBuild({ |
Contributor
Author
There was a problem hiding this comment.
this is the actual change. everything else is just version updates.
mrgrain
commented
May 28, 2026
| { | ||
| "spawn": "package:js", | ||
| "condition": "node -e \"if (!process.env.CI) process.exit(1)\"" | ||
| "spawn": "package:js" |
Contributor
Author
There was a problem hiding this comment.
This is the only functional difference to before.
Previously we wouldn't package @aws-cdk/cloud-assembly-schema locally at all during build. I believe this was not intentional, since all other packages are packaged during build.
What was intentional however was the to remove local packaging for all jsii languages (which is super slow). I have kept this removal and just re-established the package:js step.
In CI, it is important we only run package:js during build since the other packaging tasks are run in a separate job.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1565 +/- ##
=======================================
Coverage 88.18% 88.18%
=======================================
Files 76 76
Lines 10841 10841
Branches 1493 1493
=======================================
Hits 9560 9560
Misses 1253 1253
Partials 28 28
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
rix0rrr
approved these changes
May 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces the local
JsiiBuildcomponent withWorkspaceJsiiBuildfromcdklabs-projen-project-typesfor thecloud-assembly-schemapackage. This moves us to the upstream implementation, reducing local maintenance burden and keeping us aligned with the shared build infrastructure used across cdklabs projects.The remaining local
JsiiBuildclass has its NPM publishing job check commented out sinceWorkspaceJsiiBuildhandles this differently.Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license