fix(cli): route cdk destroy through toolkit-lib#1686
Merged
aws-cdk-automation merged 2 commits intoJun 30, 2026
Conversation
Contributor
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
cdk destroy through toolkit-libcdk destroy through toolkit-lib
Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
rix0rrr
approved these changes
Jun 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Routes
cdk destroythrough the toolkit-lib destroy action, the same waycdk listwas rerouted, and removes the legacyCdkToolkit.destroyimplementation.User-facing output and behavior are unchanged. The CLI keeps the destroy output identical with
CliIoHostlisteners:info(toolkit-lib emits it asresult)--forceauto-confirms the deletion prompt without showing ittoolkit-libbehavior is unchanged: its destroy action still logs the declined confirmation and returns, and the CLI turns that into the non-zero exit (by throwing from theE7010listener). The action label is preserved so a destroy triggered by a deploy still says "deployed", via a private_destroyWithAction.The destroy IO-snapshot tests assert the recorded user-facing stream is unchanged.
Technical details
dropped) messages by default, andrequestResponsemarks a suppressed prompt asdropped, so snapshots contain exactly what the user sees.Fixes #
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license