feat(toolkit-lib): Use COLUMNS env var for tables#1704
Open
faridnsh wants to merge 1 commit into
Open
Conversation
When stdout is not a TTY, process.stdout.columns is undefined and diff tables render at their unbounded natural width. CI log viewers such as CodeBuild then wrap the output and make security diffs difficult to read. Fall back to a positive integer from the COLUMNS environment variable while preserving process.stdout.columns precedence. Invalid or unset values retain the existing unbounded behavior.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When stdout is not a TTY, process.stdout.columns is undefined and diff tables render at their unbounded natural width. CI log viewers such as CodeBuild then wrap the output and make security diffs difficult to read.
This falls back to a positive integer from the COLUMNS environment variable, allowing the user to set it, while preserving process.stdout.columns precedence. Invalid or unset values retain the existing unbounded behavior.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license