Skip to content

Conversation

@mrgrain
Copy link
Contributor

@mrgrain mrgrain commented Mar 20, 2025

Updates code in lib/api to use the latest version of the modern messaging infrastructure instead of legacy helpers.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@codecov-commenter
Copy link

codecov-commenter commented Mar 20, 2025

Codecov Report

Attention: Patch coverage is 73.55372% with 32 lines in your changes missing coverage. Please review.

Project coverage is 85.44%. Comparing base (a15e73e) to head (759215c).

Files with missing lines Patch % Lines
...ckages/aws-cdk/lib/api/resource-import/importer.ts 45.45% 6 Missing ⚠️
...ages/aws-cdk/lib/api/deployments/cloudformation.ts 58.33% 5 Missing ⚠️
...s-cdk/lib/api/environment/environment-resources.ts 20.00% 4 Missing ⚠️
...dk/lib/api/garbage-collection/garbage-collector.ts 86.20% 4 Missing ⚠️
...ckages/aws-cdk/lib/api/resource-import/migrator.ts 20.00% 4 Missing ⚠️
...cdk/lib/api/stack-events/stack-activity-monitor.ts 66.66% 3 Missing ⚠️
packages/aws-cdk/lib/api/deployments/assets.ts 50.00% 2 Missing ⚠️
...ackages/aws-cdk/lib/api/deployments/deployments.ts 75.00% 2 Missing ⚠️
...ages/aws-cdk/lib/api/bootstrap/deploy-bootstrap.ts 75.00% 1 Missing ⚠️
...cdk/lib/api/garbage-collection/progress-printer.ts 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #266      +/-   ##
==========================================
+ Coverage   85.27%   85.44%   +0.16%     
==========================================
  Files         220      219       -1     
  Lines       36627    36499     -128     
  Branches     4454     4455       +1     
==========================================
- Hits        31235    31185      -50     
+ Misses       5299     5217      -82     
- Partials       93       97       +4     
Flag Coverage Δ
suite.unit 85.44% <73.55%> (+0.16%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

printer.reportDeletedAsset(deletables.slice(0, deletedCount));
}
} catch (err) {
await this.ioHelper.notify(info(chalk.red(`Error deleting images: ${err}`)));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Intentional color removal?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Intentional. Turned the red info message that says "Error" into a proper error level message, which will be colored red as well.


public async start() {
this.monitorId = uuid.v4();
await this.ioHelper.notify(debug(`Deploying ${this.stackName}`, 'CDK_TOOLKIT_I5501', {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

debug to info? intentional?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, they are info from the toolkit perspective. In our CLI we handle the Stack Monitoring messages differently (via the activity printers --progress=events and --progress=bar), so we don't actually care about the levle here.

@mrgrain mrgrain disabled auto-merge March 20, 2025 13:30
@mrgrain mrgrain force-pushed the mrgrain/refactor/modern-messaging branch from 9df2bbb to 82e0b55 Compare March 20, 2025 14:03
@mrgrain mrgrain enabled auto-merge March 20, 2025 14:03
@mrgrain mrgrain force-pushed the mrgrain/refactor/modern-messaging branch from 82e0b55 to 245ad1f Compare March 20, 2025 14:36
@mrgrain mrgrain force-pushed the mrgrain/refactor/modern-messaging branch from 245ad1f to d08b657 Compare March 20, 2025 17:02
@mrgrain mrgrain temporarily deployed to integ-approval March 20, 2025 23:15 — with GitHub Actions Inactive
@mrgrain mrgrain added this pull request to the merge queue Mar 21, 2025
Merged via the queue into main with commit 0d7bcca Mar 21, 2025
20 checks passed
@mrgrain mrgrain deleted the mrgrain/refactor/modern-messaging branch March 21, 2025 00:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants