-
Notifications
You must be signed in to change notification settings - Fork 69
refactor(cli): use modern messaging infrastructure #266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #266 +/- ##
==========================================
+ Coverage 85.27% 85.44% +0.16%
==========================================
Files 220 219 -1
Lines 36627 36499 -128
Branches 4454 4455 +1
==========================================
- Hits 31235 31185 -50
+ Misses 5299 5217 -82
- Partials 93 97 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| printer.reportDeletedAsset(deletables.slice(0, deletedCount)); | ||
| } | ||
| } catch (err) { | ||
| await this.ioHelper.notify(info(chalk.red(`Error deleting images: ${err}`))); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Intentional color removal?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Intentional. Turned the red info message that says "Error" into a proper error level message, which will be colored red as well.
|
|
||
| public async start() { | ||
| this.monitorId = uuid.v4(); | ||
| await this.ioHelper.notify(debug(`Deploying ${this.stackName}`, 'CDK_TOOLKIT_I5501', { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
debug to info? intentional?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, they are info from the toolkit perspective. In our CLI we handle the Stack Monitoring messages differently (via the activity printers --progress=events and --progress=bar), so we don't actually care about the levle here.
9df2bbb to
82e0b55
Compare
82e0b55 to
245ad1f
Compare
245ad1f to
d08b657
Compare
Updates code in
lib/apito use the latest version of the modern messaging infrastructure instead of legacy helpers.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license