feat(toolkit): add a return type for toolkit.rollback() #334
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rix0rrr
force-pushed
the
huijbers/rollback-return
branch
2 times, most recently
from
0312bf6 to
86db484
Compare
rix0rrr
force-pushed
the
huijbers/destroy-return
branch
from
71eb7ff to
e54e964
Compare
rix0rrr
force-pushed
the
huijbers/rollback-return
branch
from
86db484 to
db5115a
Compare
`toolkit.rollback()` now returns information about the stacks it rolled back.
rix0rrr
force-pushed
the
huijbers/rollback-return
branch
from
db5115a to
0d18215
Compare
Signed-off-by: github-actions <github-actions@github.com>
otaviomacedo
approved these changes
Apr 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
toolkit.rollback()now returns information about the stacks it rolled back.Includes some refactoring that deduplicates return information between deploy/destroy and rollback.
Closes aws/aws-cdk#33188
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license