Skip to content

fix(integ-runner): fail with correct error when integ manifest exists but cannot be loaded#692

Merged
aws-cdk-automation merged 4 commits intomainfrom
mrgrain/fix/integ-runner/improve-error-handling
Jul 8, 2025
Merged

fix(integ-runner): fail with correct error when integ manifest exists but cannot be loaded#692
aws-cdk-automation merged 4 commits intomainfrom
mrgrain/fix/integ-runner/improve-error-handling

Conversation

@mrgrain
Copy link
Contributor

@mrgrain mrgrain commented Jul 8, 2025

Previously if an integ manifest exists, but could not be loaded for some reason we would be falling back to the deprecated legacy style tests. This code path will than always fail with a misleading error: "integ-runner" can only operate on apps with a single stack. The error is because the modern integ tests always have include stacks, but legacy tests only handle a single stack or a pragma list.

This change improves the error handling to distinguish between "no integ manifest" and "failed to load manifest". For the former, we still go down the legacy test route. For the latter we can now fail the test with an accurate error message.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@aws-cdk-automation aws-cdk-automation requested a review from a team July 8, 2025 10:07
@github-actions github-actions bot added the p2 label Jul 8, 2025
@codecov-commenter
Copy link

codecov-commenter commented Jul 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.41%. Comparing base (19f3b5e) to head (09f8115).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #692   +/-   ##
=======================================
  Coverage   79.41%   79.41%           
=======================================
  Files          49       49           
  Lines        7358     7358           
  Branches      818      818           
=======================================
  Hits         5843     5843           
  Misses       1496     1496           
  Partials       19       19           
Flag Coverage Δ
suite.unit 79.41% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mrgrain mrgrain force-pushed the mrgrain/fix/integ-runner/improve-error-handling branch from 2d76307 to 25e3b2a Compare July 8, 2025 10:48
@mrgrain mrgrain changed the title fix(integ-runner): improve error handling for test case failures fix(integ-runner): fail with correct error when integ manifest exists but cannot be loaded Jul 8, 2025
@mrgrain mrgrain temporarily deployed to integ-approval July 8, 2025 13:59 — with GitHub Actions Inactive
@aws-cdk-automation aws-cdk-automation added this pull request to the merge queue Jul 8, 2025
Merged via the queue into main with commit ded7ae1 Jul 8, 2025
27 checks passed
@aws-cdk-automation aws-cdk-automation deleted the mrgrain/fix/integ-runner/improve-error-handling branch July 8, 2025 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants