fix(integ-runner): fail with correct error when integ manifest exists but cannot be loaded#692
Merged
aws-cdk-automation merged 4 commits intomainfrom Jul 8, 2025
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #692 +/- ##
=======================================
Coverage 79.41% 79.41%
=======================================
Files 49 49
Lines 7358 7358
Branches 818 818
=======================================
Hits 5843 5843
Misses 1496 1496
Partials 19 19
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
2d76307 to
25e3b2a
Compare
rix0rrr
approved these changes
Jul 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously if an integ manifest exists, but could not be loaded for some reason we would be falling back to the deprecated legacy style tests. This code path will than always fail with a misleading error:
"integ-runner" can only operate on apps with a single stack.The error is because the modern integ tests always have include stacks, but legacy tests only handle a single stack or a pragma list.This change improves the error handling to distinguish between "no integ manifest" and "failed to load manifest". For the former, we still go down the legacy test route. For the latter we can now fail the test with an accurate error message.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license