fix(cli): "cdk flags" message writes to stderr unconditionally
#790
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rix0rrr
had a problem deploying
to
integ-approval
GitHub Actions
Failure
mrgrain
approved these changes
Aug 13, 2025
rix0rrr
force-pushed
the
huijbers/update-messaging
branch
from
a3d3feb to
89685cd
Compare
rix0rrr
had a problem deploying
to
integ-approval
GitHub Actions
Failure
rix0rrr
force-pushed
the
huijbers/update-messaging
branch
from
89685cd to
d287fcc
Compare
rix0rrr
had a problem deploying
to
integ-approval
GitHub Actions
Failure
rix0rrr
force-pushed
the
huijbers/update-messaging
branch
from
d287fcc to
e6571db
Compare
rix0rrr
had a problem deploying
to
integ-approval
GitHub Actions
Failure
This ignores our rules for avoiding writing to `stderr` in CI environments. Use the IoHost instead. Also update the message to include the use of the unstable flag.
rix0rrr
force-pushed
the
huijbers/update-messaging
branch
from
e6571db to
e4d161c
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #790 +/- ##
==========================================
- Coverage 81.38% 81.37% -0.01%
==========================================
Files 63 63
Lines 8554 8555 +1
Branches 1031 1031
==========================================
Hits 6962 6962
- Misses 1560 1561 +1
Partials 32 32
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
iankhou
pushed a commit
that referenced
this pull request
Aug 21, 2025
This ignores our rules for avoiding writing to `stderr` in CI environments. Use the IoHost instead. Also update the message to include the use of the unstable flag. --- By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ignores our rules for avoiding writing to
stderrin CI environments. Use the IoHost instead.Also update the message to include the use of the unstable flag.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license