fix(opensearchservice): enableAutoSoftwareUpdate: false is not reflected in the CloudFormation template#37152
Merged
mergify[bot] merged 3 commits intoaws:mainfrom Mar 4, 2026
Conversation
…abling it The truthiness check on `enableAutoSoftwareUpdate` treated `false` as falsy, causing `SoftwareUpdateOptions` to be omitted from the template entirely. This made it impossible to disable auto software update once it had been enabled. Changed the check from `props.enableAutoSoftwareUpdate ? ...` to `props.enableAutoSoftwareUpdate !== undefined ? ...` so that an explicit `false` value is correctly rendered in the CloudFormation template. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
badmintoncryer
temporarily deployed
to
automation
GitHub Actions
Inactive
badmintoncryer
temporarily deployed
to
automation
GitHub Actions
Inactive
badmintoncryer
temporarily deployed
to
automation
GitHub Actions
Inactive
github-actions
bot
added
p2
distinguished-contributor
aws-cdk-automation
previously requested changes
Mar 3, 2026
badmintoncryer
temporarily deployed
to
automation
GitHub Actions
Inactive
Contributor
Author
|
exemption request |
aws-cdk-automation
added
the
pr-linter/exemption-requested
aws-cdk-automation
temporarily deployed
to
automation
GitHub Actions
Inactive
badmintoncryer
temporarily deployed
to
automation
GitHub Actions
Inactive
badmintoncryer
temporarily deployed
to
automation
GitHub Actions
Inactive
badmintoncryer
changed the title
enableAutoSoftwareUpdate: false is not reflected in the CloudFormation template
badmintoncryer
temporarily deployed
to
automation
GitHub Actions
Inactive
leonmk-aws
added
the
pr-linter/exempt-integ-test
aws-cdk-automation
added
the
pr/needs-community-review
aws-cdk-automation
dismissed
their stale review
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
aws-cdk-automation
temporarily deployed
to
automation
GitHub Actions
Inactive
aws-cdk-automation
temporarily deployed
to
automation
GitHub Actions
Inactive
mrgrain
approved these changes
Mar 3, 2026
Contributor
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
mrgrain
removed
pr/needs-community-review
Contributor
Merge Queue StatusRule:
This pull request spent 13 hours 15 minutes 30 seconds in the queue, including 43 minutes 22 seconds running CI. Required conditions to merge
|
Contributor
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Contributor
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Contributor
|
Comments on closed issues and PRs are hard for our team to see. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Relates to #36382 (review thread).
Reason for this change
The truthiness check on
enableAutoSoftwareUpdatetreatedfalseas falsy, causingSoftwareUpdateOptionsto be omitted from the CloudFormation template entirely. This made it impossible to disable auto software update once it had been enabled.Description of changes
Changed the condition from
props.enableAutoSoftwareUpdate ? ...toprops.enableAutoSoftwareUpdate !== undefined ? ...so that an explicitfalsevalue is correctly rendered in the template. This is consistent with the existing pattern used forcoldStorageEnabledin the same file.Description of how you validated changes
Add unit test.
Checklist