fix(ec2): availabilityZones can be empty for Vpc causing subsequent subnet errors #33993
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
beginning-contributor
aws-cdk-automation
requested changes
Apr 1, 2025
Collaborator
There was a problem hiding this comment.
The pull request linter fails with the following errors:
❌ Fixes must contain a change to an integration test file and the resulting snapshot.
If you believe this pull request should receive an exemption, please comment and provide a justification. A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed, add Clarification Request to a comment.
✅ A exemption request has been requested. Please wait for a maintainer's review.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #33993 +/- ##
=======================================
Coverage 82.39% 82.39%
=======================================
Files 120 120
Lines 6960 6960
Branches 1175 1175
=======================================
Hits 5735 5735
Misses 1120 1120
Partials 105 105
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
gravitylow
force-pushed
the
32451
branch
2 times, most recently
from
b34a1b9 to
73ae970
Compare
Author
|
Exemption Request for "Fixes must contain a change to an integration test file and the resulting snapshot." -- the fix involves throwing an error at build time and won't end up deploying a stack. A unit test exercising the behavior of the fix was added. |
aws-cdk-automation
added
pr-linter/exemption-requested
Contributor
|
Thank you @gravitylow for submitting this, while i agree that there should be a validation to check whether the availabilty zones is an empty array or not, i also think it is not a good definition of setting an availability zone as '[]' in the Vpc definition, few concerns that I have to add this validation and if we can verify that this doesn't affect those existing implementations will be good to go:
For the exemption request, we can try running the existing integration test just to confirm that these are working fine along with additional unit tests for the scenario's mentioned above. |
shikha372
removed
the
pr-linter/exemption-requested
aws-cdk-automation
removed
the
pr/needs-community-review
Author
|
Hey @shikha372 thanks for your review and feedback. Addressing specific points below:
For the The unrelated error which is thrown from this test case is: (I am actually not immediately sure if this is desirable behavior, it's a bit of a buggy message since of course 0 is a multiple of 0. But seems to handle the concerning case anyway...) |
shikha372
reviewed
Apr 21, 2025
Contributor
Thank you @gravitylow , changing this to a warning should not result in any snapshot changes and is least intrusive as well, |
Collaborator
|
This PR has been in the CHANGES REQUESTED state for 3 weeks, and looks abandoned. Note that PRs with failing linting check or builds are not reviewed, please ensure your build is passing To prevent automatic closure:
This PR will automatically close in 14 days if no action is taken. |
Collaborator
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Author
|
Thanks for making the requested change to the warning message. Please let me know if there are any outstanding actions on my side and I'll be happy to address them. |
Collaborator
|
This PR has been deemed to be abandoned, and will be automatically closed. Please create a new PR for these changes if you think this decision has been made in error. |
aws-cdk-automation
added
the
closed-for-staleness
Contributor
|
Comments on closed issues and PRs are hard for our team to see. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue # (if applicable)
Closes #32451
Reason for this change
When creating a Vpc construct and specifying a list of availability zones to use for creating subnets with, passing an empty list causing misleading and confusing errors to happen with other Vpc features. See #32451 for further details and examples.
Description of changes
I added a simple check to throw an error when at least one subnet is going to be created, but the provided availabilityZones to use is empty.
Describe any new or updated permissions being added
N/A
Description of how you validated changes
Added a unit test and confirm it fails with the misleading error message prior to fixing the issue:
Fixed the issue and confirm the test now passes, along with others:
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license