feat(kms): make trustAccountIdentities optional in KeyGrants#36786
Merged
mergify[bot] merged 2 commits intomainfrom Jan 23, 2026
Merged
feat(kms): make trustAccountIdentities optional in KeyGrants#36786mergify[bot] merged 2 commits intomainfrom
trustAccountIdentities optional in KeyGrants#36786mergify[bot] merged 2 commits intomainfrom
Conversation
mrgrain
approved these changes
Jan 23, 2026
aws-cdk-automation
previously requested changes
Jan 23, 2026
aws-cdk-automation
added
the
pr/needs-further-review
otaviomacedo
added
pr-linter/exempt-readme
aws-cdk-automation
dismissed
their stale review
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
Contributor
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Contributor
Merge Queue Status✅ The pull request has been merged at 4a3ca05 This pull request spent 6 seconds in the queue, with no time running CI. Required conditions to merge
|
Contributor
|
Comments on closed issues and PRs are hard for our team to see. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason for this change
The
KeyGrants.fromKey()method requires the user to decide whether they want to add permission to both the principal and the resource or just the principal. This is hard to reason about and most of the time customers just want a sensible default.Description of changes
The parameter
trustAccountIdentitiestoKeyGrants.fromKey()is being made optional, and defaults to the value of the@aws-cdk/aws-kms:defaultKeyPoliciesfeature flag.Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license