feat(ecr-assets): add support for docker build context#36930
Open
feat(ecr-assets): add support for docker build context#36930
Conversation
aws-cdk-automation
previously requested changes
Feb 10, 2026
Contributor
|
|
||||||||||||||
Contributor
|
|
||||||||||||||
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
520b1c1 to
329214b
Compare
Add support for docker's --build-context flag in docker builds. Fixes aws#31598
1b3bd62 to
a60f41a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue # (if applicable)
Fixes #31598
Reason for this change
Add support for docker's
--build-contextflag in docker builds. This is useful for a few reasons outlined in the linked issue (and other similar issues), such as:docker-image://alpine:latest)Description of changes
Adds support for Docker's
--build-contextflag when building Docker image assets. This allows users to specify additional named build contexts that can be referenced in Dockerfiles viaCOPY --from=<name>.buildContexts(optionalRecord<string, string>) toDockerBuildOptions,DockerImageAssetOptions,DockerImageAssetInvalidationOptions, andDockerImageAssetSourceDockerImage.fromBuild()to pass--build-context key=valueflags to the docker build commandbuildContextsthrough the full asset pipeline:DockerImageAsset→ synthesizer → asset manifest → cloud assembly schemabuildContextskeys and values (same asbuildArgs)buildContextsto asset hash invalidation (controllable viainvalidation.buildContexts)ASSET_RESOURCE_METADATA_DOCKER_BUILD_CONTEXTS_KEYmetadata constantaws-ecr-assetsREADME with documentation and usage exampleIn terms of design decisions, this follows the same pattern as
buildArgs.This requires the CLI changes in aws/aws-cdk-cli#1128 to be released first.
Describe any new or updated permissions being added
N/A
Description of how you validated changes
Integration test, using linked local AWS CDK CLI with changes from aws/aws-cdk-cli#1128
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license