Skip to content

fix(spec2cdk): add grants.json path mapping for alpha modules#36974

Open
irem-kaya wants to merge 12 commits intoaws:mainfrom
irem-kaya:fix/grants-json-alpha-modules
Open

fix(spec2cdk): add grants.json path mapping for alpha modules#36974
irem-kaya wants to merge 12 commits intoaws:mainfrom
irem-kaya:fix/grants-json-alpha-modules

Conversation

@irem-kaya
Copy link

@irem-kaya irem-kaya commented Feb 12, 2026

Closes #36963

This PR adds grants.json path mapping support for alpha modules in spec2cdk.

Changes made:

  • Added grantsJsonPathOverrides mapping for aws-bedrockagentcore module
  • Updated generatetsconfig function to handle alpha module path resolution
  • Added test case for alpha modules with non-standard directory names

How tested:

  • Tested manually with alpha modules
  • Verified path mapping works correctly for aws-bedrockagentcore-alpha

@github-actions github-actions bot added the p2 label Feb 12, 2026
@aws-cdk-automation aws-cdk-automation requested a review from a team February 12, 2026 13:54
@github-actions github-actions bot added the beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK label Feb 12, 2026
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter fails with the following errors:

❌ Fixes must contain a change to an integration test file and the resulting snapshot.

If you believe this pull request should receive an exemption, please comment and provide a justification. A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed, add Clarification Request to a comment.

@irem-kaya irem-kaya changed the title Fix/grants json alpha modules fix(spec2cdk): Add grants.json path mapping for alpha modules Feb 12, 2026
@irem-kaya irem-kaya changed the title fix(spec2cdk): Add grants.json path mapping for alpha modules fix(spec2cdk): add grants.json path mapping for alpha modules Feb 16, 2026
@irem-kaya irem-kaya closed this Feb 16, 2026
@irem-kaya irem-kaya reopened this Feb 16, 2026
@github-actions
Copy link
Contributor

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions
Copy link
Contributor

This issue has been reopened and is now available for discussion.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 16, 2026
@github-actions github-actions bot unlocked this conversation Feb 16, 2026
@irem-kaya irem-kaya marked this pull request as draft February 16, 2026 09:15
@irem-kaya irem-kaya marked this pull request as ready for review February 16, 2026 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK p2

Projects

None yet

Development

Successfully merging this pull request may close these issues.

(spec2cdk): Alpha module directory naming convention prevents grants.json processing for aws-bedrock-agentcore-alpha

3 participants