feat(route53): support intermediate role for CrossAccountZoneDelegationRecord#36975
Open
feat(route53): support intermediate role for CrossAccountZoneDelegationRecord#36975
Conversation
aws-cdk-automation
requested changes
Feb 12, 2026
Collaborator
aws-cdk-automation
left a comment
There was a problem hiding this comment.
The pull request linter fails with the following errors:
❌ Features must contain a change to an integration test file and the resulting snapshot.
If you believe this pull request should receive an exemption, please comment and provide a justification. A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed, add Clarification Request to a comment.
Author
|
Clarification Request: Per contributing guide, if integ tests are unable to be run, "please call this out on the pull request so a maintainer can run the tests for you". This is noted in PR description. Let me know if I should include resultant snapshots myself. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
No existing issue - this PR highlights a limitation and proposes a solution.
Reason for this change
The current
CrossAccountZoneDelegationRecordconstruct requires the under-the-hood Custom Resource's Lambda execution role to directly assume the delegation role in the parent account. This limits flexibility for teams that need role chaining for various architectural reasons.For my team specifically, managing zone delegation across hundreds of accounts has hit IAM trust policy size limits on the delegation role. Using an intermediate role as a single trust point solves this scaling issue. The usage of intermediate roles is a developed solution for our application to interface with other AWS accounts for other use-cases- without needing the other AWS accounts to maintain a list of hundreds of accounts. This PR allows usage for maintaining our R53 record.
Description of changes
Added optional
intermediateRoleparameter toCrossAccountZoneDelegationRecordthat enables role chaining:Changes:
intermediateRoleoptional property to constructmasterCredentialsDescription of how you validated changes
/bin/bash run-rosetta.shfor README changesinteg.zone-delegation-iam-stack.tswith--update-on-failedinteg.cross-account-zone-delegation.tsfrom the cross-account specifics required. As such, I did not check in any snapshot changes. Can a maintainer run these tests?Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license