feat: added channel mixins for ElementalMediaPackage-V2#37071
feat: added channel mixins for ElementalMediaPackage-V2#37071
Conversation
There was a problem hiding this comment.
The pull request linter fails with the following errors:
❌ Features must contain a change to a README file.
❌ Features must contain a change to an integration test file and the resulting snapshot.
If you believe this pull request should receive an exemption, please comment and provide a justification. A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed, add Clarification Request to a comment.
aws-cdk-automation
added
the
pr/needs-further-review
| construct.node.addValidation({ | ||
| validate: () => { | ||
| const inputType = construct.inputType; | ||
| if (inputType && inputType !== 'CMAF') { |
There was a problem hiding this comment.
Why are we not making this already part of the mixin? if the idea of this is to go and apply the MQCS config, should it also set the correct type?
| return; | ||
| } | ||
|
|
||
| new CfnChannelPolicy(construct, 'Policy', { |
There was a problem hiding this comment.
If a policy already exists (lets assume the L2 constructor still accepts props for that to happen), then this will try to add a second cfnChannelPolicy, and I that that is not supported and will fail
3 participants
Issue # (if applicable)
Closes #.
Reason for this change
Description of changes
Describe any new or updated permissions being added
Description of how you validated changes
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license