fix(docdb): fix serverless cluster setup#37087
Open
dimmy-timmy wants to merge 4 commits intoaws:mainfrom
Open
Conversation
closes aws#37011 Adds serverless instances provisioning support for docdb cluster via separate serverlessInstances property. Allows to create mixed cluster with both serverless and provisioned instances closes - useful for real production use to simplify transition. Added new validations - to make sure cluster is created with at least serverlessInstances or instances set greater > 0. Added new validations - to make sure that serverlessV2ScalingConfiguration is presented when serverlessInstances > 0.
github-actions
Bot
added
beginning-contributor
Contributor
|
|
||||||||||||||
Contributor
|
|
||||||||||||||
Author
|
Issue #37011 was closed by mistake. Looks like there was some CI issue . |
aws-cdk-automation
added
the
pr/needs-community-review
Author
* main: (27 commits) chore(deps): bump dawidd6/action-download-artifact from 15 to 16 (aws#37136) chore: add enum updater lerna.json (aws#36755) chore(docdb): upgrade integ tests to engine 8.0.0 and add serverless region constraints (aws#37059) chore(github): add `environment: automation` to workflow jobs and fix formatting (aws#37140) chore(deps): bump actions/upload-artifact from 6 to 7 (aws#37138) chore(deps): bump actions/download-artifact from 7 to 8 (aws#37137) chore(spec2cdk): handle undefined properties in the reference interfaces (aws#37040) chore: update Contributors File (aws#37129) chore(cloudformation-include): remove hardcoded S3 bucket names from integ test templates (aws#37069) Update CHANGELOG.v2.md chore: update analytics metadata blueprints chore(release): 2.241.0 fix: bump minimatch to ^10.2.3 to resolve ReDoS vulnerabilities (aws#37127) feat: update L1 CloudFormation resource definitions (aws#37103) chore(msk-alpha): fix integ tests - update deprecated Kafka versions (aws#37084) docs(s3): fix addEventNotification docstring examples for correct Rosetta translation (aws#37104) fix(events): correct docs on schema discovery and CMK encryption (aws#37102) feat(core): introducing CDK Mixins (aws#37055) chore(mixins-preview): enum name must be a valid typescript identifier (aws#37099) chore: bump @aws-cdk/asset-node-proxy-agent-v6 to ^2.1.1 (aws#37098) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #37011
Closes #37011
Reason for this change
Current serverless configuration creates cluster without instances at all which makes cluster unusable.
Description of changes
Adds serverless instances provisioning support for docdb cluster via separate
serverlessInstancesproperty.Allows to create mixed cluster with both serverless and provisioned instances closes - useful for real production use to simplify transition.
Added new validations - to make sure cluster is created with at least
serverlessInstancesor instances set greater > 0.Added new validations - to make sure that
serverlessV2ScalingConfigurationis presented whenserverlessInstances> 0.Description of how you validated changes
Added new and updated existing unit and integration tests which verify:
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license