chore(stepfunctions-tasks): fix 5 failing integration tests#37154
Open
aemada-aws wants to merge 2 commits intoaws:mainfrom
Open
chore(stepfunctions-tasks): fix 5 failing integration tests#37154aemada-aws wants to merge 2 commits intoaws:mainfrom
aemada-aws wants to merge 2 commits intoaws:mainfrom
Conversation
Contributor
|
|
||||||||||||||||||||||
Contributor
|
|
||||||||||||||
- integ.invoke-model-guardrail-trace: replace EOL Titan Text G1 Express with Nova Micro, update request format, remove resultSelector/resultPath (guardrail blocks input), add region constraint - integ.call-aws-service-cross-region-lambda: use stack region instead of hardcoded us-east-1 so Lambda is reachable - integ.create-training-job-image: add us-east-1 region constraint for BlazingText ECR account, use execution name for unique training job name, add bucket cleanup policy, increase assertion timeout - integ.emr-create-cluster-with-auto-deletion-policy-idle-timeout: add expectError on destroy for EMR VPC teardown failures - integ.emr-create-cluster-with-ebs: add expectError on destroy for EMR VPC teardown failures
7751f5c to
975c7e4
Compare
- Remove incorrect issue link (aws#19275 is ECS, not EMR) from EMR expectError comments - Replace with accurate description of EMR ENI teardown race condition - Remove stale manual-cleanup comment on SageMaker bucket (now auto-deleted) - Add region justification comments for Bedrock and SageMaker tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue # (if applicable)
N/A — Integration test remediation.
Reason for this change
5 of 7 integration tests in
aws-stepfunctions-taskswere failing due to:integ.invoke-model-guardrail-trace): Amazon Titan Text G1 Express reached End-of-Life on August 15, 2025 and is no longer available in any region.integ.call-aws-service-cross-region-lambda): Test creates a Lambda in the stack's region but invokes it via the us-east-1 Lambda endpoint. Lambda Invoke API is regional — calling us-east-1 with an ARN from another region returns ResourceNotFoundException.integ.create-training-job-image): Hardcoded ECR account811284229777for BlazingText is only valid for us-east-1. Hardcoded training job name causes NAME_COLLISION on re-runs. S3 bucket had no cleanup policy.integ.emr-create-cluster-with-auto-deletion-policy-idle-timeout,integ.emr-create-cluster-with-ebs): EMR clusters create ENIs in VPC subnets that linger after cluster termination, preventing VPC/subnet deletion during stack teardown.Description of changes
integ.invoke-model-guardrail-trace.ts:
AMAZON_TITAN_TEXT_G1_EXPRESS_V1withAMAZON_NOVA_MICRO_V1_0inputText/textGenerationConfig) to Nova format (messages/inferenceConfig)resultSelectorandresultPath— the guardrail blocks the "test attack" input (word filter), and the blocked response body doesn't contain the model output structureregionsconstraint for Nova Micro + Guardrails supported regionsinteg.call-aws-service-cross-region-lambda.ts:
region: 'us-east-1'toregion: this.region— uses the stack's own region so the Lambda is reachableinteg.create-training-job-image.ts:
regions: ['us-east-1']constraint to IntegTest (BlazingText ECR account is us-east-1 specific)trainingJobNamewithJsonPath.format('BlazingText-{}', JsonPath.executionName)for unique namesremovalPolicy: DESTROYandautoDeleteObjects: trueto S3 bucketinteg.emr-create-cluster-with-auto-deletion-policy-idle-timeout.ts:
cdkCommandOptions: { destroy: { expectError: true } }for known EMR VPC teardown failuresinteg.emr-create-cluster-with-ebs.ts:
cdkCommandOptions: { destroy: { expectError: true } }for known EMR VPC teardown failuresDescribe any new or updated permissions being added
bedrock:InvokeModelonamazon.titan-text-express-v1toamazon.nova-micro-v1:0Description of how you validated changes
All 7 tests validated via integ-runner deployment:
Note: IntegTest
regionsproperty is NOT respected by integ-runner--parallel-regions. Region-constrained tests (bedrock, sagemaker) must be run with only their supported regions.Destructive change:
sfn-sm-training-job-imagestack —TrainSetAwsCliLayer57B94C48will be replaced (asset hash change from adding auto-delete objects).Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license