feat(s3-deployment): add architecture property to BucketDeployment#37174
Open
badmintoncryer wants to merge 10 commits intoaws:mainfrom
Open
feat(s3-deployment): add architecture property to BucketDeployment#37174badmintoncryer wants to merge 10 commits intoaws:mainfrom
badmintoncryer wants to merge 10 commits intoaws:mainfrom
Conversation
aws-cdk-automation
previously requested changes
Mar 5, 2026
Contributor
|
|
||||||||||||||
Contributor
|
|
||||||||||||||||||||||||||||||||||||||
d1b7170 to
ae66043
Compare
ae66043 to
1afe1b0
Compare
1afe1b0 to
137e8ca
Compare
137e8ca to
bc269b1
Compare
bc269b1 to
0fbca07
Compare
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
Add an `architecture` property to `BucketDeploymentProps` so users can configure the Lambda function architecture (e.g. ARM_64/Graviton) for cost savings and sustainability improvements. - Pass architecture through to BucketDeploymentSingletonFunction - Include architecture in singleton UUID to isolate different configs - Declare compatibleArchitectures on AwsCliLayer for both x86_64/arm64 - Add unit tests for architecture passthrough, singleton isolation, default behavior, and combined memoryLimit scenarios - Update README with Lambda Architecture section Closes aws#29996 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…chitectures Update 103 template.json and 100 tree.json snapshot files to include the CompatibleArchitectures property added to AwsCliLayer. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
… zip asset The Rosetta build failed because the architecture code example was missing `import * as lambda from 'aws-cdk-lib/aws-lambda'`. Also re-tracked the integration test zip asset through Git LFS to fix check-lfs CI. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
c33d4d0 to
5df0e4b
Compare
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…ployment-architecture
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue # (if applicable)
Closes #29996.
Reason for this change
BucketDeploymentdoes not expose anarchitectureproperty, so users cannot use ARM_64 (Graviton) Lambda.Description of changes
architectureprop toBucketDeploymentPropsand pass through to singleton handlercompatibleArchitectures: [X86_64, ARM_64]toAwsCliLayerDescribe any new or updated permissions being added
N/A
Description of how you validated changes
Added both unit and integration tests.
Note on snapshot changes
Adding
compatibleArchitecturestoAwsCliLayercausesCompatibleArchitecturesproperty to appear in everyAWS::Lambda::LayerVersionresource generated byAwsCliLayer. SinceAwsCliLayeris used across many modules (s3-deployment, eks, eks-v2, stepfunctions-tasks, codepipeline-actions, dynamodb, elasticloadbalancingv2, etc.), this results in 203 snapshot file updates (103 template.json + 100 tree.json).The actual change per resource is minimal — only adding the metadata property:
This does not cause resource replacement or any runtime behavior change.
CompatibleArchitecturesis an informational property that CloudFormation uses only for validation.Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license