chore(eks-v2): update integ tests for eks-addon and eks-cluster-removal-policy#37236
Draft
aemada-aws wants to merge 1 commit intomainfrom
Draft
chore(eks-v2): update integ tests for eks-addon and eks-cluster-removal-policy#37236aemada-aws wants to merge 1 commit intomainfrom
aemada-aws wants to merge 1 commit intomainfrom
Conversation
…-policy - integ.eks-addon: replace coredns with snapshot-controller to avoid conflict with default EKS addon, add configurationValues (logLevel: 3), remove expectError on destroy - integ.eks-cluster-removal-policy: update snapshots
Contributor
|
|
||||||||||||||
Contributor
|
|
||||||||||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue # (if applicable)
N/A
Reason for this change
Two
aws-eks-v2integration tests needed fixes to deploy successfully:corednsas the addon under test, which conflicts with the default EKS-managed coredns addon installed on every cluster. This caused deployment and teardown failures, requiringexpectError: trueon destroy as a workaround.arn:aws:iam::123456789012:user/test-user) for the AccessEntry principal, which fails deployment since the ARN doesn't exist. The HelmChart also lacked an explicit dependency on the ALB Controller, causing intermittent failures when the webhook wasn't ready.Description of changes
integ.eks-addon:
corednsaddon withsnapshot-controllerto avoid conflict with the default EKS addonpreserveOnDelete: trueandconfigurationValues(usinglogLevel: 3) to maintain test coverage of addon configurationexpectError: trueon destroy sincesnapshot-controllertears down cleanlyinteg.eks-cluster-removal-policy:
iam.Roleresource for the AccessEntry principal so the stack actually deployshelmChart.node.addDependency(albController)) to ensure the webhook is ready before chart installationDescribe any new or updated permissions being added
N/A
Description of how you validated changes
Both tests deployed and destroyed successfully:
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license