Skip to content

feat : use account‑regional suffix for default staging bucket#37252

Open
naaa760 wants to merge 3 commits intoaws:mainfrom
naaa760:feat/botstrp-accnt-reg-suff-stg-bukt
Open

feat : use account‑regional suffix for default staging bucket#37252
naaa760 wants to merge 3 commits intoaws:mainfrom
naaa760:feat/botstrp-accnt-reg-suff-stg-bukt

Conversation

@naaa760
Copy link

@naaa760 naaa760 commented Mar 15, 2026

Issue # (if applicable)

Closes #37245.

Reason for this change

  • Default staging buckets were not using the S3 account‑regional namespace, leaving names open to squatting.

Description of changes

  • Append -an to the default staging bucket name in DefaultStagingStack.
  • Update unit tests to expect the new bucket name and URLs.
  • Refresh integ snapshots to match the -an suffixed bucket names.

Describe any new or updated permissions being added

  • None. No IAM roles or policies were added or changed.
  • Description of how you validated changes
  • Updated and ran the @aws-cdk/app-staging-synthesizer-alpha tests.
  • Regenerated and reviewed affected integration snapshots.

naaa760 added 3 commits March 15, 2026 15:00
Append -an to the default staging bucket name to align with S3 account regional namespace naming.

Made-with: Cursor
Update unit tests to match the default staging bucket name ending with -an.

Made-with: Cursor
Refresh integration snapshots to match the default staging bucket name ending with -an.

Made-with: Cursor
@github-actions github-actions bot added effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p2 beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK labels Mar 15, 2026
@aws-cdk-automation aws-cdk-automation requested a review from a team March 15, 2026 09:47
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter fails with the following errors:

❌ Features must contain a change to a README file.
❌ Features must contain a change to an integration test file and the resulting snapshot.
❌ The title prefix of this pull request must be one of "feat|fix|build|chore|ci|docs|style|refactor|perf|test|revert"

If you believe this pull request should receive an exemption, please comment and provide a justification. A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed, add Clarification Request to a comment.

@aws-cdk-automation aws-cdk-automation added the pr/needs-further-review PR requires additional review from our team specialists due to the scope or complexity of changes. label Mar 15, 2026
@dehli
Copy link
Contributor

dehli commented Mar 15, 2026

Awesome! From the docs, it seems like there will be a new BucketNamespace property on the S3 bucket resource in CloudFormation. Does this change work without setting that property (which I don't think has landed yet).

Edit: confirmed this won't work due to the missing namespace on the bucket

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p2 pr/needs-further-review PR requires additional review from our team specialists due to the scope or complexity of changes.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bootstrap: Utilize Account Regional namespace suffix for default StagingBucket

3 participants