fix(lambda): calculateLayersHash includes all stack layers (Reopened)#37295
Open
Abhinandansinha01 wants to merge 2 commits intoaws:mainfrom
Open
fix(lambda): calculateLayersHash includes all stack layers (Reopened)#37295Abhinandansinha01 wants to merge 2 commits intoaws:mainfrom
Abhinandansinha01 wants to merge 2 commits intoaws:mainfrom
Conversation
added 2 commits
January 30, 2026 00:21
Previously, calculateFunctionHash was including all layers from the stack (fn._layers) in the hash calculation, even if they were not attached to the function. This caused unrelated layer changes to trigger function updates. This change filters fn._layers to only include those present in the function's CloudFormation properties. Signed-off-by: Abhinandan Sinha <abhinandansinha239@gmail.com>
aws-cdk-automation
requested changes
Mar 20, 2026
Collaborator
aws-cdk-automation
left a comment
There was a problem hiding this comment.
The pull request linter fails with the following errors:
❌ Fixes must contain a change to an integration test file and the resulting snapshot.
If you believe this pull request should receive an exemption, please comment and provide a justification. A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed, add Clarification Request to a comment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #36713. Reopening my original PR #36818.
Exemption Request: I am unable to generate the integration test snapshot locally on Windows because
aws-cdk-libisn't fully built in my environment. I have provided the functionality and the integration test code. Could a maintainer assist in generating the test snapshot or approve the exemption for the PR checkout? Thanks!