fix(s3-deployment): custom logGroup of BucketDeployment is prevented from deletion#37337
Open
syukawa-gh wants to merge 1 commit intoaws:mainfrom
Open
fix(s3-deployment): custom logGroup of BucketDeployment is prevented from deletion#37337syukawa-gh wants to merge 1 commit intoaws:mainfrom
syukawa-gh wants to merge 1 commit intoaws:mainfrom
Conversation
…from deletion Ensure the log group is not deleted before the Lambda handler during stack deletion by adding a dependency from the handler to the log group. Closes aws#35632
github-actions
bot
added
bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ensure the log group is not deleted before the Lambda handler during stack deletion by adding a dependency from the handler to the log group.
Closes #35632
Supersedes #37309 (fixed: accidentally overwrote existing integ test file)