fix(redshift-alpha): replace deprecated Provider role with frameworkOnEventRole#37465
fix(redshift-alpha): replace deprecated Provider role with frameworkOnEventRole#37465syukawa-gh wants to merge 2 commits intoaws:mainfrom
Conversation
There was a problem hiding this comment.
The pull request linter fails with the following errors:
❌ Fixes must contain a change to an integration test file and the resulting snapshot.
If you believe this pull request should receive an exemption, please comment and provide a justification. A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed, add Clarification Request to a comment.
✅ A exemption request has been requested. Please wait for a maintainer's review.
…nEventRole The DatabaseQuery construct was using the deprecated 'role' property on custom_resources.Provider, which triggers deprecation warnings during synthesis. Replaced with 'frameworkOnEventRole' which is the recommended replacement. Closes aws#37006
9aeb6c9 to
6dcf7e4
Compare
|
Exemption Request: This change is a minimal fix that does not alter CloudFormation resource behavior in a way that requires a new integration test. The fix is covered by unit tests. |
|
Exemption Request: This fix replaces the deprecated |
Issue
Closes #37006
Reason for this change
The
DatabaseQueryconstruct inaws-redshift-alphawas using the deprecatedroleproperty oncustom_resources.Provider, which triggers deprecation warnings during synthesis:Description of changes
Replaced
rolewithframeworkOnEventRolein theProviderconstructor call indatabase-query.ts. Since the RedshiftDatabaseQueryconstruct does not useisCompleteHandler, only theframeworkOnEventRoleis needed (noframeworkCompleteAndTimeoutRolerequired).The behavior is functionally equivalent — the same IAM role is assigned to the framework's onEvent Lambda function.
Description of how you validated changes
frameworkOnEventRoleis the documented replacement for the deprecatedrolepropertyProviderimplementation shows thatroleandframeworkOnEventRoleare applied to the same Lambda function viathis.role ?? roleincreateFunction()isCompleteHandleris used, so only the onEvent role is relevantChecklist