fix(core): synth output is not valid YAML when using policy validation#37597
Merged
mergify[bot] merged 5 commits intomainfrom Apr 16, 2026
Merged
fix(core): synth output is not valid YAML when using policy validation#37597mergify[bot] merged 5 commits intomainfrom
mergify[bot] merged 5 commits intomainfrom
Conversation
aws-cdk-automation
previously requested changes
Apr 14, 2026
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
Tests were asserting on consoleLogMock for messages that now go to console.error. Updated all test assertions to read from consoleErrorMock with adjusted call indices since 'Performing Policy Validations' is now also on stderr (index 0), shifting the report to index 1.
rix0rrr
approved these changes
Apr 15, 2026
Contributor
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Contributor
Merge Queue Status
This pull request spent 10 seconds in the queue, including 1 second running CI. Required conditions to merge
|
Contributor
|
Comments on closed issues and PRs are hard for our team to see. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #25331
Reason for this change
According to synth docs, CDK is supposed to support
cdk synth > template.ymlWhen using policy validation, some outputs are being written to stdout. This makes the stdout not valid YAML (in situations where we specify a single stack and thus write the YAML template to stdout).
Description of changes
Instead of writing to stdout, we write to stderr. This is a pattern established elsewhere in CDK where we reserve stdout for the YAML template. No new tests; only the output channel is being changed and is reflected in updated tests.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license