feat(ecs): add hookDetails support for deployment lifecycle hooks#37698
Open
rgoltz wants to merge 6 commits into
Open
feat(ecs): add hookDetails support for deployment lifecycle hooks#37698rgoltz wants to merge 6 commits into
rgoltz wants to merge 6 commits into
Conversation
…tails support - lifecycle hooks
Contributor
|
|
||||||||||||||||||
Contributor
|
|
||||||||||||||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue # (if applicable)
N/A
Reason for this change
The
AWS::ECS::ServiceCloudFormation resource supports aHookDetailsfield onDeploymentConfiguration.LifecycleHooks, but the CDK L2 construct does not expose it. This field allows passing custom parameters (as a JSON object) to lifecycle hook targets (e.g. Lambda functions) during ECS deployments.Description of changes
hookDetailsproperty (Record<string, unknown>) toDeploymentLifecycleLambdaTargetPropshookDetails(string) to the internalDeploymentLifecycleHookTargetConfiginterfaceFn.toJsonStringto correctly handle CDK tokens at synth timeDeploymentLifecycleHookTargetConfigintobase-service.tsNote: When
hookDetailscontains CDK tokens (e.g.cdk.Aws.STACK_NAME), the synthesized template will useFn::ToJsonString, which requires theAWS::LanguageExtensionstransform. CDK adds this transform automatically.Describe any new or updated permissions being added
None.
Description of how you validated changes
integ.blue-green-deployment-strategy) to includehookDetailsChecklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license