fix(codepipeline): clean up cross-region replication buckets#37880
Open
nanookclaw wants to merge 2 commits into
Open
fix(codepipeline): clean up cross-region replication buckets#37880nanookclaw wants to merge 2 commits into
nanookclaw wants to merge 2 commits into
Conversation
aws-cdk-automation
previously requested changes
May 15, 2026
Author
|
Added the integration-test coverage requested by the PR linter in The follow-up enables Verification run after the snapshot update:
|
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue # (if applicable)
Closes #35654.
Reason for this change
CodePipeline cross-region support stacks currently retain their replication bucket by default, which can leave an orphaned bucket after destroying the pipeline stack. Because changing the default removal policy could be disruptive for existing deployments, this adds the cleanup behavior behind an opt-in feature flag.
Description of changes
@aws-cdk/aws-codepipeline:crossRegionReplicationBucketDestroyas a recommended feature flag.RemovalPolicy.DESTROYandautoDeleteObjects: true.Description of how you validated changes
PATH=/tmp/yarn-bin:$PATH npx lerna run build --scope aws-cdk-lib --skip-nx-cache --streamcd packages/aws-cdk-lib && node ../../node_modules/jest/bin/jest.js --config jest.config.js cx-api/test/features.test.ts aws-codepipeline/test/cross-env.test.ts --runInBand --coverage=falsecd packages/aws-cdk-lib && NODE_OPTIONS='--max-old-space-size=8192' ../../node_modules/.bin/eslint aws-codepipeline/lib/private/cross-region-support-stack.ts aws-codepipeline/test/cross-env.test.ts cx-api/lib/features.ts cx-api/test/features.test.tsChecklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license