SNS publiish documentation incorrect

[alam0rt]

Confirm by changing [ ] to [x] below to ensure that it's a bug:

• I've gone though the User Guide and the API reference
• I've searched for previous similar issues and didn't find any solution

Describe the bug
The documentation here fails to mention the correct short-hand syntax for the aws sns publish subcommand.

SDK version number
aws-cli/1.16.300 Python/2.7.16 Linux/4.14.171-136.231.amzn2.x86_64 botocore/1.13.36

To Reproduce (observed behavior)
incorrect (as per documentation):
aws sns publish ... --message-attributes 'KeyName1=DataType=string,StringValue=string'

correc (notice DataType needs to be 'String' rather than 'string'):
aws sns publish ... --message-attributes 'KeyName1={DataType=String,StringValue=string}'

Expected behavior
Expect the message to be published with the correct message attributes

Logs/output
Invalid type for parameter MessageAttributes.InstanceId, value: DataType=string, type: <type 'unicode'>, valid types: <type 'dict'>

[nateprewitt]

Hi @alam0rt,

Thanks for opening an issue on this! We're currently tracking this for a couple spots in the docs where this has cropped up. Unfortunately, these shorthand examples are autogenerated so it's not as straight forward as updating a line in the docs.

Once we're able to get that resolved, the docs should start displaying these correctly. Let's go ahead and use this as the tracking issue for now.

[wangshu3000]

Tried to fix this in this PR. Can anyone please have a review?
https://github.com/aws/aws-cli/pull/7286/files

[erpel]

5 years later and I still need to spend a lot of time googling to find this report with the correct examples.
If updating the autogenerated examples is not easy, at least put a note into the freeform text, hinting at the mistake in the autogenerated example.