Add ResultProcessor #2114
Add ResultProcessor #2114
Conversation
Abstraction is a thread that processes results in the result queue by passing each result from the queue to the ResultRecorder and ResultPrinter.
| except queue.Empty: | ||
| pass | ||
|
|
||
| def _process_result(self, result): |
There was a problem hiding this comment.
Is it worth just having a generic ResultHandler interface and having the __init__ take a list of result handlers? You could then either write adapters for the recorder/printer or update them to have the same interface.
What do you think?
There was a problem hiding this comment.
Posssibly. I was actually considering doing that. The only reason I did not was because I did not see needing it in doing the port, but taking an arbitrary list of handlers is pretty flexible so I would be totally fine with making that the interface.
There was a problem hiding this comment.
Yeah, don't feel too strongly about it for this specific PR, it would just clean up the code a little bit:
for handler in self._result_handlers:
handler.handle_result(result)
vs. having to check if a particular handler was None or not.
There was a problem hiding this comment.
I'm updating it. I did not like the None check either.
It now accepts a list of handlers to call when processing through the result queue.
|
I assume we're going to just change the existing recorder/printer to just have a |
|
@jamesls I realized that as well when I was looking over the first commit I pushed. You just beat me to it. I went a head and changed the interface to use |
|
|
2 participants
Abstraction is a thread that processes results in the result queue by
passing each result from the queue to the ResultRecorder and ResultPrinter.
cc @jamesls @JordonPhillips