Copy textwriter.py from botocore project#4917
Closed
jwhitlock wants to merge 1 commit into
Closed
Conversation
botocore/docs/bcdoc/textwriter.py is not used by botocore, and may be deleted in botocore to remove the docutils dependency.
Codecov Report
@@ Coverage Diff @@
## develop #4917 +/- ##
===========================================
- Coverage 93.94% 92.25% -1.69%
===========================================
Files 189 190 +1
Lines 14524 15080 +556
===========================================
+ Hits 13644 13912 +268
- Misses 880 1168 +288
Continue to review full report at Codecov.
|
Member
|
Hi @jwhitlock, I think this will be taken care of by #5538. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re issue #4719, botocore/docs/bcdoc/textwriter.py is not used by botocore, and may be deleted in botocore to remove the docutils dependency. This PR imports the code into this project. There are no related tests to import.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.