Skip to content

Copy textwriter.py from botocore project#4917

Closed
jwhitlock wants to merge 1 commit into
aws:developfrom
jwhitlock:4719-import-textwriter
Closed

Copy textwriter.py from botocore project#4917
jwhitlock wants to merge 1 commit into
aws:developfrom
jwhitlock:4719-import-textwriter

Conversation

@jwhitlock

Copy link
Copy Markdown

Re issue #4719, botocore/docs/bcdoc/textwriter.py is not used by botocore, and may be deleted in botocore to remove the docutils dependency. This PR imports the code into this project. There are no related tests to import.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

botocore/docs/bcdoc/textwriter.py is not used by botocore, and may be
deleted in botocore to remove the docutils dependency.
@codecov-io

codecov-io commented Feb 4, 2020

Copy link
Copy Markdown

Codecov Report

Merging #4917 into develop will decrease coverage by 1.68%.
The diff coverage is 47.93%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #4917      +/-   ##
===========================================
- Coverage    93.94%   92.25%   -1.69%     
===========================================
  Files          189      190       +1     
  Lines        14524    15080     +556     
===========================================
+ Hits         13644    13912     +268     
- Misses         880     1168     +288
Impacted Files Coverage Δ
awscli/help.py 96.48% <100%> (ø) ⬆️
awscli/textwriter.py 47.84% <47.84%> (ø)
awscli/customizations/ec2/bundleinstance.py 100% <0%> (+2.77%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c29c90e...e7c75e6. Read the comment docs.

@kdaily

kdaily commented Sep 15, 2020

Copy link
Copy Markdown
Member

Hi @jwhitlock, I think this will be taken care of by #5538. Thanks!

@kdaily kdaily closed this Sep 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants