Skip to content

Update create-data-catalog.rst#6122

Merged
kyleknap merged 1 commit intoaws:developfrom
DavidIndrawes2:patch-1
May 28, 2021
Merged

Update create-data-catalog.rst#6122
kyleknap merged 1 commit intoaws:developfrom
DavidIndrawes2:patch-1

Conversation

@DavidIndrawes2
Copy link
Copy Markdown

Was using the wrong parameter name

Issue #, if available:
Wrong parameter name on an example

Description of changes:
Fixed the example

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link
Copy Markdown
Member

@kdaily kdaily left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @DavidIndrawes2, thanks for catching that. Can you fix the change to the last line? It doesn't seem like you made any changes, but maybe a new line was added or removed. Please squash your commits afterwards. If you need any help with that, let us know!

@kdaily kdaily added documentation This is a problem with documentation. pr:blocked This PR cannot be merged or reviewed, because it is blocked for some reason. labels Apr 27, 2021
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Apr 27, 2021

Codecov Report

Merging #6122 (00e8d45) into develop (75cc41d) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #6122   +/-   ##
========================================
  Coverage    93.04%   93.04%           
========================================
  Files          204      204           
  Lines        16201    16201           
========================================
  Hits         15075    15075           
  Misses        1126     1126           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 75cc41d...00e8d45. Read the comment docs.

@DavidIndrawes2
Copy link
Copy Markdown
Author

hey @kdaily I have pushed an update, it was the ^M line ending

@kdaily kdaily assigned kdaily and unassigned DavidIndrawes2 Apr 29, 2021
@kdaily kdaily added pr:ready-to-merge This PR is ready to be merged. and removed pr:blocked This PR cannot be merged or reviewed, because it is blocked for some reason. labels Apr 30, 2021
Copy link
Copy Markdown
Contributor

@kyleknap kyleknap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Merging.

@kyleknap kyleknap merged commit bf7cc31 into aws:develop May 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation This is a problem with documentation. pr:ready-to-merge This PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants