Update create-data-catalog.rst#6122
Merged
kyleknap merged 1 commit intoaws:developfrom May 28, 2021
Merged
Conversation
kdaily
requested changes
Apr 27, 2021
Member
kdaily
left a comment
There was a problem hiding this comment.
Hi @DavidIndrawes2, thanks for catching that. Can you fix the change to the last line? It doesn't seem like you made any changes, but maybe a new line was added or removed. Please squash your commits afterwards. If you need any help with that, let us know!
Codecov Report
@@ Coverage Diff @@
## develop #6122 +/- ##
========================================
Coverage 93.04% 93.04%
========================================
Files 204 204
Lines 16201 16201
========================================
Hits 15075 15075
Misses 1126 1126 Continue to review full report at Codecov.
|
Author
|
hey @kdaily I have pushed an update, it was the ^M line ending |
kdaily
approved these changes
Apr 29, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Was using the wrong parameter name
Issue #, if available:
Wrong parameter name on an example
Description of changes:
Fixed the example
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.