CLI examples for ec2, elasticache, globalaccelerator, kms, securityhu…#6192
CLI examples for ec2, elasticache, globalaccelerator, kms, securityhu…#6192kyleknap merged 2 commits intoaws:developfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #6192 +/- ##
========================================
Coverage 93.05% 93.05%
========================================
Files 204 204
Lines 16201 16201
========================================
Hits 15076 15076
Misses 1125 1125 Continue to review full report at Codecov.
|
kyleknap
left a comment
kyleknap
left a comment
There was a problem hiding this comment.
Looks good. Just had some comments about line breaks
| --output text \ | ||
| Before running this command, replace the example key ID with a valid key ID from your AWS account. :: | ||
|
|
||
| aws kms decrypt ^ |
There was a problem hiding this comment.
I'm not sure if ^ character is appropriate here? I'd assume we would want the \ instead for line break
There was a problem hiding this comment.
Talked offline the characters are for command prompt. I did not see the title of the example. We can ignore my comment.
|
|
||
| aws kms re-encrypt ^ | ||
| --ciphertext-blob fileb://ExampleEncryptedFile ^ | ||
| --source-key-id 1234abcd-12ab-34cd-56ef-1234567890ab ^ |
There was a problem hiding this comment.
Same thing here. I think we would want to be using \ instead of ^
| --output text ^ | ||
| --query Plaintext > ExamplePlaintextFile.base64 | ||
|
|
||
| Run the ''certutil'' command. :: |
There was a problem hiding this comment.
We probably should be using `` instead of '' to enclose certutil to make a code literal
|
|
||
| The following ``list-documents`` example lists shared documents, including private shared documents not owned by AWS. :: | ||
|
|
||
| aws ssm list-documents / |
There was a problem hiding this comment.
I think we need to change this from a / to a \
| The following ``batch-import-findings`` example updates a finding. :: | ||
|
|
||
| aws securityhub batch-import-findings \ | ||
| aws securityhub batch-import-findings |
There was a problem hiding this comment.
I'm not sure if we want to remove the backslash here since the --findings parameter is on a new line.
3 participants
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.