Pin Python version of source dist tests until PyInstaller upgrade #9343
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kdaily
approved these changes
Mar 4, 2025
Member
kdaily
left a comment
kdaily
left a comment
There was a problem hiding this comment.
LGTM. I see in the CI for windows that its using 3.9.13 and 3.10.11, earlier versions as expected than the ones pinned for Mac/Linux.
Member
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: N/A
Description of changes: Pinning the Python versions of 3.9 and 3.10 that are still compatible with our current PyInstaller version until we address the issues that led to #9332
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.