Upgrade to PyInstaller 6.11.1 #9382
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Bump PyInstaller to 6.11.1 This includes pinning `macholib` because of this change in `PyInstaller` that makes `macholib` a build dependency. pyinstaller/pyinstaller#5883 --------- Co-authored-by: Github Actions <> Co-authored-by: Steve Yoo <hssyoo@amazon.com> Co-authored-by: Alex Shovlin <shovlia@amazon.com>
hssyoo
approved these changes
Mar 18, 2025
Contributor
hssyoo
left a comment
hssyoo
left a comment
There was a problem hiding this comment.
Assuming installer validation looks good 🏆
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: This reapplies our PyInstaller 6 upgrade from #9194 which was reverted via #9332, with fixes for the two issues that led to the revert:
Description of changes: This cherry-picks the original commit from merging #9194, with the two additional PRs listed above applied on top of it.
[In Progress] Repeating our installer verification steps from the internal runbook
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.