[v2] Remove PyInstaller LD_LIBRARY_PATH from pager #9434
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hssyoo
changed the title
hssyoo
commented
Apr 11, 2025
hssyoo
changed the title
hssyoo
force-pushed
the
remove_ld_library_path_from_pager
branch
from
9d2d63b to
a5d2aca
Compare
ashovlin
approved these changes
Apr 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9433
The AWS CLI calls out to the system's pager, which may share dynamic libraries with the AWS CLI. This can cause issues if an AWS CLI library is incompatible with the system's pager. Although the system owns the pager, because it's executed as a child of the AWS CLI's Python process, it inherits PyInstaller's
LD_LIBRARY_PATH. This commit fixes the issue by retrieving kwargs for pager popen under theoriginal_ld_library_pathcontext manager. The effect is that the system's pager uses the the system's dependencies instead of the AWS CLI's.