Merged
Conversation
The default behavior for which STS endpoint to use is changing from global to regional. These tests assume that the global endpoint will always be used, which is not the case for the default behavior from the botocore client. This change updates the tests to reflect that the regional endpoint will be used.
kdaily
force-pushed
the
update-eks-tests-for-sts-default-endpoint-change
branch
from
a5714bc to
26a10d4
Compare
ashovlin
reviewed
Jul 31, 2025
Member
ashovlin
left a comment
ashovlin
left a comment
There was a problem hiding this comment.
Given the CI failures here, it might be better to explicitly set legacy or regional for the STS setting for each test case. That way we're not reliant on the botocore version or environment settings.
Member
Author
We agreed separately that we should have a test for STS defaults, but would follow up separately. To change this test we would need to mock the session or set an environment variable, since the CLI does not have a command line parameter to set |
jonathan343
approved these changes
Jul 31, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
The default behavior for which STS endpoint to use is changing from global to regional.
These tests previously assumed that the global endpoint will always be used, which is will not be the case for the default behavior from the botocore client once boto/botocore#3517 is merged. This change updates the tests to reflect that the regional endpoint will be used.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.