-
Notifications
You must be signed in to change notification settings - Fork 4.4k
Reduced false positive upgrade warnings for URL parameters #9899
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduced false positive upgrade warnings for URL parameters #9899
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## debug-migration #9899 +/- ##
================================================
Coverage 93.32% 93.32%
================================================
Files 209 209
Lines 16909 16911 +2
================================================
+ Hits 15780 15783 +3
+ Misses 1129 1128 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| if v2_debug and fail_on_empty_changeset: | ||
| uni_print( | ||
| 'AWS CLI v2 UPGRADE WARNING: In AWS CLI v2, ' | ||
| '\nAWS CLI v2 UPGRADE WARNING: In AWS CLI v2, ' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might not matter at this point, but could have been nice to wrap all of these in a print_migration_debug_message
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
True, one caveat is, code under /customizations should use uni_print, and all other code should use print. May need a boolean arg to choose between either. Does this approach sound good with you?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't need to see changes at this point, more for future projects if we ever follow a similar pattern again.
Description of changes:
\n.parsed_globalsglobals args to theload-cli-argevent.Description of tests:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.