Add monitor-mode to monitor mutating commands #9931
Merged
+561
−105
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aemous
requested changes
Dec 17, 2025
Contributor
aemous
left a comment
aemous
left a comment
There was a problem hiding this comment.
Looks good! Great test coverage.
I have a few questions and nits.
aemous
requested changes
Dec 18, 2025
Contributor
aemous
left a comment
aemous
left a comment
There was a problem hiding this comment.
After some manual testing of the mutating commands, looks like I ran into an error. Can we address this?
% aws ecs create-express-gateway-service --monitor-resources DEPLOYMENT --monitor-mode TEXT-ONLY --execution-role-arn arn:aws:iam::${AWS_ACCOUNT}:role/ecsTaskExecutionRole \
--infrastructure-role-arn arn:aws:iam::${AWS_ACCOUNT}:role/EcsExpressServicesInfraRole \
--primary-container '{
"image": "public.ecr.aws/nginx/nginx:1.28-alpine3.21-slim"
}'
[2025-12-18 10:45:19] Starting monitoring...
[2025-12-18 10:45:19] Polling for updates...
[2025-12-18 10:45:20] Cluster arn:aws:ecs:<REGION>:<ID>:cluster/default
[2025-12-18 10:45:20] Service arn:aws:ecs:<REGION>:<ID>:service/default/nginx-37e3
[2025-12-18 10:45:20] Waiting for a deployment to start
[2025-12-18 10:45:25] Polling for updates...
[2025-12-18 10:45:25] Waiting for a deployment to start
[2025-12-18 10:45:30] Polling for updates...
[2025-12-18 10:45:31] Monitoring complete!
'ManagedResourceGroup' object has no attribute 'diff'
After a quick search of the code, this might be due to the target_sr_resources.diff(source_sr_resources_combined) call in ServiceViewCollector, from renaming the diff function in a previous PR.
Author
fixed |
aemous
merged commit 134d926
into
aws:ecs-express-gateway-text-only
57 of 60 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Add monitor-mode to monitor mutating commands
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.