Use port 80 (HTTP) for PHP GPG key reception #204
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: N/A
Description of changes: I was having trouble building the
ubuntu/standard/2.0image behind a firewall. When the Python GPG key is received, it tries to use a port 80 (HTTP) server first:aws-codebuild-docker-images/ubuntu/standard/2.0/Dockerfile
Line 152 in d5a24df
This modifies the PHP part to use the same server, which unblocked the build. Might be useful for some other consumers in the future? If not, feel free to close the PR.
(I've left trailing whitespace as is, since #192 addresses that, but merging that PR would much appreciated for people who's editors are set up to work with whitespace-sensitive languages :) )
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.