[joysl] Neptune Autoscaling #180
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With this commit, user can choose to enable Neptune Autoscaling along with following configurable paramters [TargetUtilization, MinCapacity,MaxCapacity]
canavandl
reviewed
Dec 18, 2023
Contributor
canavandl
left a comment
canavandl
left a comment
There was a problem hiding this comment.
I checked out this CR and locally built/deployed the AssetLibrary module and confirmed that the Neptune autoscaling settings are applied as intended
source/packages/services/assetlibrary/infrastructure/cfn-autoscaling-neptune.yml
Outdated
Show resolved
Hide resolved
source/packages/services/assetlibrary/infrastructure/cfn-assetLibrary.yaml
Outdated
Show resolved
Hide resolved
canavandl
reviewed
Dec 18, 2023
Comment on lines
+353
to
+355
| # Optional Neptune auto-scaling configuration | ||
| AutoScalingNeptuneNestedStack: | ||
| Type: AWS::CloudFormation::Stack |
Contributor
There was a problem hiding this comment.
Open question: What's the benefit of having this be a nested stack instead of part of the top-level one?
Contributor
Author
There was a problem hiding this comment.
Just decided to follow what was set for Lambda autoscaling which was a nested stack.
aalaabed
approved these changes
Jan 10, 2024
Contributor
|
Thanks @joysl ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this commit, user can choose to enable Neptune Autoscaling along with following configurable paramters [TargetUtilization, MinCapacity,MaxCapacity]
Description
With this commit, user can choose to enable Neptune Autoscaling along with following configurable paramters [TargetUtilization, MinCapacity,MaxCapacity]
Type of change
Submission Checklist
Additional Notes: